Skip to content

Commit f95ffde

Browse files
authored
Merge pull request #3526 from bitjammer/remote-mirror-version-hidden
[IRGen] Use hidden visibility for __swift_reflection_version constant
2 parents 698028a + 14192bf commit f95ffde

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

lib/IRGen/GenReflection.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -938,5 +938,6 @@ void IRGenModule::emitReflectionMetadataVersion() {
938938
llvm::GlobalValue::LinkOnceODRLinkage,
939939
Init,
940940
"__swift_reflection_version");
941+
Version->setVisibility(llvm::GlobalValue::HiddenVisibility);
941942
addUsedGlobal(Version);
942943
}

test/IRGen/reflection_metadata.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
// STRIP_REFLECTION_METADATA-NOT: @"\01l__swift3_reflection_metadata"
2424

25+
// CHECK-DAG: @__swift_reflection_version = linkonce_odr hidden constant i16 {{[0-9]+}}
2526
// CHECK-DAG: private constant [2 x i8] c"i\00", section "{{[^"]*}}swift3_reflstr{{[^"]*}}"
2627
// CHECK-DAG: private constant [3 x i8] c"ms\00", section "{{[^"]*}}swift3_reflstr{{[^"]*}}"
2728
// CHECK-DAG: private constant [3 x i8] c"me\00", section "{{[^"]*}}swift3_reflstr{{[^"]*}}"

0 commit comments

Comments
 (0)