Skip to content

Commit fa85160

Browse files
committed
[test] lit: Delay setting up %env- substitutions until we have target_env_prefix fully configured
This resolves variables not properly propagating through remote-run invocations during testing.
1 parent 93083f5 commit fa85160

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/lit.cfg

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1954,12 +1954,6 @@ def configure_remote_run():
19541954
remote_tmp_dir, 'bin', swift_reflection_test_name)
19551955
config.available_features.add('remote_run')
19561956

1957-
# Different OS's require different prefixes for the environment variables to be
1958-
# propagated to the calling contexts.
1959-
# In order to make tests OS-agnostic, names of environment variables should be
1960-
# prefixed with `%env-`, which is then expanded to the appropriate prefix.
1961-
config.substitutions.append(('%env-', config.target_env_prefix))
1962-
19631957
config.substitutions.append(("%target-sdk-name", config.target_sdk_name))
19641958

19651959
simulator_sdks = [
@@ -2286,6 +2280,12 @@ if platform.system() != 'Darwin' or swift_test_mode == 'optimize_none_with_impli
22862280
# When changing substitutions, update docs/Testing.md.
22872281
#
22882282

2283+
# Different OS's require different prefixes for the environment variables to be
2284+
# propagated to the calling contexts.
2285+
# In order to make tests OS-agnostic, names of environment variables should be
2286+
# prefixed with `%env-`, which is then expanded to the appropriate prefix.
2287+
config.substitutions.append(('%env-', config.target_env_prefix))
2288+
22892289
config.substitutions.append(('%target-clangxx', '%s -std=c++11' % config.target_clang))
22902290
config.substitutions.append(('%target-swiftxx-frontend', '%s -enable-experimental-cxx-interop' % config.target_swift_frontend))
22912291

0 commit comments

Comments
 (0)