AST: Don't crash when computing identifier for an invalid extension.

tshortli · tshortli · commit fb3972c2cc7a · 2023-08-31T09:53:49.000-07:00
diff --git a/lib/AST/FrontendSourceFileDepGraphFactory.cpp b/lib/AST/FrontendSourceFileDepGraphFactory.cpp
@@ -67,7 +67,8 @@ static std::string identifierForContext(const DeclContext *DC) {
 
   const auto *ext = cast<ExtensionDecl>(DC);
   auto fp = ext->getBodyFingerprint().value_or(Fingerprint::ZERO());
-  auto typeStr = Mangler.mangleTypeAsContextUSR(ext->getExtendedNominal());
+  const auto *nominal = ext->getExtendedNominal();
+  auto typeStr = nominal ? Mangler.mangleTypeAsContextUSR(nominal) : "";
   return (typeStr + "@" + fp.getRawValue()).str();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,8 @@ static std::string identifierForContext(const DeclContext *DC) {`
`67`	`67`
`68`	`68`	`const auto *ext = cast<ExtensionDecl>(DC);`
`69`	`69`	`auto fp = ext->getBodyFingerprint().value_or(Fingerprint::ZERO());`
`70`		`- auto typeStr = Mangler.mangleTypeAsContextUSR(ext->getExtendedNominal());`
	`70`	`+ const auto *nominal = ext->getExtendedNominal();`
	`71`	`+ auto typeStr = nominal ? Mangler.mangleTypeAsContextUSR(nominal) : "";`
`71`	`72`	`return (typeStr + "@" + fp.getRawValue()).str();`
`72`	`73`	`}`
`73`	`74`