[cxx-interop] only ban strstr, sin, cos, and exit on darwin where the conflict with declarations in the Darwin module; improve the test.

Author: zoecarver

lib/ClangImporter/ImportDecl.cpp

@@ -3197,15 +3197,18 @@ namespace {
         // presence in the C++ standard library will cause overloading
         // ambiguities or other type checking errors in Swift.
         auto isAlternativeCStdlibFunctionFromTextualHeader =
-            [](const clang::FunctionDecl *d) -> bool {
+            [this](const clang::FunctionDecl *d) -> bool {
           // stdlib.h might be a textual header in libc++'s module map.
           // in this case, check for known ambiguous functions by their name
           // instead of checking if they come from the `std` module.
           if (!d->getDeclName().isIdentifier())
             return false;
-          return d->getName() == "abs" || d->getName() == "div" ||
-              d->getName() == "strstr" || d->getName() == "sin" ||
-              d->getName() == "cos" || d->getName() == "exit";
+          if (d->getName() == "abs" || d->getName() == "div")
+            return true;
+          if (Impl.SwiftContext.LangOpts.Target.isOSDarwin())
+            return d->getName() == "strstr" || d->getName() == "sin" ||
+                   d->getName() == "cos" || d->getName() == "exit";
+          return false;
         };
         if (decl->getOwningModule() &&
             (decl->getOwningModule()

test/Interop/Cxx/stdlib/avoid-import-cxx-math.swift

@@ -5,13 +5,15 @@
 import CxxStdlib
 
 func test() {
-    let x: Float = 1.0
-    let y: Float = 2.0
+    let x: Double = 1.0
+    let y: Double = 2.0
 
     let _ =  pow(x, y)
 
     let _ = abs(x)
     let _ = div(42, 2)
+    let _ = sin(x)
+    let _ = cos(x)
     let _ = strstr("a", "aaa")
 
     exit(0)