Merge pull request #37660 from nkcsgexi/71462726

Frontend: avoid remarking contents of module installname map

Author: nkcsgexi

include/swift/AST/DiagnosticsFrontend.def

@@ -288,12 +288,6 @@ ERROR(batch_scan_input_file_corrupted,none,
       "batch dependencies scan input file from %0 is malformed",
       (StringRef))
 
-REMARK(default_previous_install_name, none,
-      "default previous install name for %0 is %1", (StringRef, StringRef))
-
-REMARK(platform_previous_install_name, none,
-       "previous install name for %0 in %1 is %2", (StringRef, StringRef, StringRef))
-
 ERROR(unknown_platform_name, none,
       "unkown platform name %0", (StringRef))
 

lib/TBDGen/TBDGen.cpp

@@ -125,16 +125,6 @@ StringRef InstallNameStore::getInstallName(LinkerPlatformId Id) const {
     return It->second;
 }
 
-void InstallNameStore::remark(ASTContext &Ctx, StringRef ModuleName) const {
-  Ctx.Diags.diagnose(SourceLoc(), diag::default_previous_install_name,
-                     ModuleName, InstallName);
-  for (auto Pair: PlatformInstallName) {
-    Ctx.Diags.diagnose(SourceLoc(), diag::platform_previous_install_name,
-                       ModuleName, getLinkerPlatformName(Pair.first),
-                       Pair.second);
-  }
-}
-
 static std::string getScalaNodeText(Node *N) {
   SmallString<32> Buffer;
   return cast<ScalarNode>(N)->getValue(Buffer).str();
@@ -214,11 +204,6 @@ TBDGenVisitor::parsePreviousModuleInstallNameMap() {
   std::unique_ptr<std::map<std::string, InstallNameStore>> pResult(
     new std::map<std::string, InstallNameStore>());
   auto &AllInstallNames = *pResult;
-  SWIFT_DEFER {
-    for (auto Pair: AllInstallNames) {
-      Pair.second.remark(Ctx, Pair.first);
-    }
-  };
 
   // Load the input file.
   llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> FileBufOrErr =

lib/TBDGen/TBDGenVisitor.h

@@ -58,7 +58,6 @@ struct InstallNameStore {
   // the default install name.
   std::map<uint8_t, std::string> PlatformInstallName;
   StringRef getInstallName(LinkerPlatformId Id) const;
-  void remark(ASTContext &Ctx, StringRef ModuleName) const;
 };
 
 /// A set of callbacks for recording APIs.