Skip to content

[Dependency Scanning] Setting Default Clang Optimize Args Option to All #79919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[Dependency Scanning] Setting Default Clang Optimize Args Option to All #79919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/AST/ModuleDependencies.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,13 @@ SwiftDependencyScanningService::SwiftDependencyScanningService() {
clang::CASOptions(),
/* CAS (llvm::cas::ObjectStore) */ nullptr,
/* Cache (llvm::cas::ActionCache) */ nullptr,
/* SharedFS */ nullptr);
/* SharedFS */ nullptr,
// ScanningOptimizations::Default excludes the current working
// directory optimization. Clang needs to communicate with
// the build system to handle the optimization safely.
// Swift can handle the working directory optimizaiton
// already so it is safe to turn on all optimizations.
clang::tooling::dependencies::ScanningOptimizations::All);
SharedFilesystemCache.emplace();
}

Expand Down Expand Up @@ -748,7 +754,11 @@ bool SwiftDependencyScanningService::setupCachingDependencyScanningService(
ClangScanningFormat,
Instance.getInvocation().getCASOptions().CASOpts,
Instance.getSharedCASInstance(), Instance.getSharedCacheInstance(),
UseClangIncludeTree ? nullptr : CacheFS);
UseClangIncludeTree ? nullptr : CacheFS,
// The current working directory optimization (off by default)
// should not impact CAS. We set the optization to all to be
// consistent with the non-CAS case.
clang::tooling::dependencies::ScanningOptimizations::All);

return false;
}
Expand Down