[rebranch] SIL: Restore old behavior in llvm::APInt ctor call
#81464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ctor" The approach taken in the reverted commit is causing tests to fail, and I am not positive that all instances of the -1 to 1 switch are correct. A subsequent commit will restore the old behavior by tweaking the ctor call instead. This reverts commit 657f502.
bnbarham
approved these changes
May 13, 2025
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
Happy to take for now to unblock things, but would be good to get @aschwaighofer / @drexin to weigh in on the truncation (even if that's just to remove the TODO).
AnthonyLatsis
added a commit
that referenced
this pull request
Aug 21, 2025
Follow-up to #81464. Fixes an assertion failure on 32-bit Windows. The default value was flipped in llvm/llvm-project#114539.
rjmccall
reviewed
Aug 21, 2025
| return APInt(intTy->getGreatestWidth(), value); | ||
| // TODO: Avoid implicit trunc? | ||
| return APInt(intTy->getGreatestWidth(), value, /*isSigned=*/false, | ||
| /*implicitTrunc=*/true); |
Contributor
There was a problem hiding this comment.
If we're getting implicit truncation here, I feel like that's genuinely problematic and we should get an assertion.
| SILValue minusOne = B.createIntegerLiteral(loc, i1, -1); | ||
| booleanTestValue = | ||
| B.createBuiltinBinaryFunction(loc, "xor", i1, i1, | ||
| {booleanTestValue, minusOne}); |
Contributor
There was a problem hiding this comment.
We conventionally talk about single bits as 0 and 1, not 0 and -1. So I don't like the renaming, and if we've done something to make it necessary to pass -1 instead of 1 to the constructor here, that seems bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#114539.
The approach taken in the reverted commit is causing tests to fail, and I am not positive that all instances of the -1 to 1 switch are correct. Restore the old behavior by tweaking the ctor call instead.