[CSDiagnostics] Prevent nested type references in KeyPath components #83625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemfpeixoto
requested review from
hborla,
slavapestov and
xedin
as code owners
|
This is not about constraint generation but avoid preventing references to nested types in key path components, the title should reflect that. |
felipemfpeixoto
changed the title
Fixed! |
xedin
changed the title
|
@felipemfpeixoto I adjusted it some more, could you please amend your commit to reflect the change as well? |
This change adds detection for nested type references in KeyPath components and applies the appropriate fix to generate meaningful error messages, following the same pattern already established for method references. The fix ensures that invalid KeyPath references fail gracefully in normal mode and provide helpful diagnostics in diagnostic mode, improving the developer experience when working with KeyPaths. Resolves: swiftlang#83197
felipemfpeixoto
force-pushed
the
issue83197
branch
from
c1e5802 to
fe1d926
Compare
xedin
approved these changes
Aug 11, 2025
| func testKeypathWithTypeReference() { | ||
| struct S { | ||
| enum Q { | ||
| static let i = 1 |
There was a problem hiding this comment.
Nit: the indentation is off here a bit, we use 2 spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds detection for nested type references in KeyPath components and applies the appropriate fix to generate meaningful error messages, following the same pattern already established for method references.
The fix ensures that invalid KeyPath references fail gracefully in normal mode and provide helpful diagnostics in diagnostic mode, improving the developer experience when working with KeyPaths.
Resolves: #83197