[Completion] Fall back to unqualified lookup on solver failure #83662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the solver fails we can still do an unqualified lookup without a contextual type.
With the unqualified fallback we start to hit this assertion for `return nil` in failable intializers. We ought to be able to just skip over literal buckets though.
hamishknight
force-pushed
the
unqualified-fallback
branch
from
f6a9cb9 to
a3edf17
Compare
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
bnbarham
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the solver fails we can still do an unqualified lookup without a contextual type.