Skip to content

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Sep 11, 2025

#82616 added a new exposure kind for the @_expose attribute, but did not update the serialization format to account for the new kind. This caused a crash when serializing a module that used @_expose(wasm).

Close #84196 #84140

swiftlang#82616 added a new exposure kind
for the `@_expose` attribute, but did not update the serialization
format to account for the new kind. This caused a crash when
serializing a module that used `@_expose(wasm)`.
@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix! 🙇

@MaxDesiatov MaxDesiatov added serialization Area → compiler: Serialization & deserialization WebAssembly Platform: WebAssembly labels Sep 11, 2025
@MaxDesiatov MaxDesiatov moved this to In Progress in Swift for Wasm Sep 11, 2025
@kateinoigakukun kateinoigakukun merged commit ce39d0f into swiftlang:main Sep 11, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Swift for Wasm Sep 11, 2025
@kkebo
Copy link
Contributor

kkebo commented Sep 21, 2025

Will this change be cherry-picked into the release/6.2 branch?

#82616 was also merged into the release/6.2 branch in #84053, so if we don't cherry-pick #84215 into the release/6.2 branch, #84053 will cause regressions in Swift 6.2.2.

P.S. I created an issue. #84431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

serialization Area → compiler: Serialization & deserialization WebAssembly Platform: WebAssembly

Projects

Status: Done

4 participants