Improve error message when integer overflow happens #84700
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… way integer types are displayed to users when detecting overflows. Instead of showing, for example, Builtin.Int, it will show the integer type name as declared by the user.
|
@rintaro @xedin @AnthonyLatsis hey, could you do review on this? |
rintaro
reviewed
Oct 8, 2025
There was a problem hiding this comment.
Thank you for working on this!
I'm not really a person to review this area, but I think this is a matter of how UserDstTy is derived from Loc, rather than how to display the built-in type. For example, in the case of #83877, with your change, the diagnostic would display UInt64, but it should be UInt.
I would look into how to derive UserDstTy to UInt using Loc.getAsASTNode<>()
Also, please add test cases 🙇♂️
| case 8: return Ctx.getInt8Type(); | ||
| case 16: return Ctx.getInt16Type(); | ||
| case 32: return Ctx.getInt32Type(); | ||
| case 64: return Ctx.getInt64Type(); |
There was a problem hiding this comment.
You'd need default:. Also there is (U)Int128.
| // Since builtin types are sign-agnostic, print the signedness | ||
| // separately. | ||
| // separately | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to improve, as stated in issue #83877, the way integer types are displayed to users when detecting overflows. Instead of showing, for example, Builtin.Int, it will show the integer type name as declared by the user for example Uint8.