Create a special xcode selector that will delegates to xcrun

Author: cmcgee1024

Sources/MacOSPlatform/MacOS.swift

@@ -207,9 +207,15 @@ public struct MacOS: Platform {
         return "/bin/zsh"
     }
 
-    public func findToolchainLocation(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) -> URL
-    {
-        self.swiftlyToolchainsDir(ctx).appendingPathComponent("\(toolchain.identifier).xctoolchain")
+    public func findToolchainLocation(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) async throws -> URL {
+        if toolchain == .xcodeVersion {
+            // Print the toolchain location with the help of xcrun
+            if let xcrunLocation = try? await self.runProgramOutput("/usr/bin/xcrun", "-f", "swift") {
+                return URL(filePath: xcrunLocation.replacingOccurrences(of: "\n", with: "")).deletingLastPathComponent().deletingLastPathComponent().deletingLastPathComponent()
+            }
+        }
+
+        return self.swiftlyToolchainsDir(ctx).appendingPathComponent("\(toolchain.identifier).xctoolchain")
     }
 
     public static let currentPlatform: any Platform = MacOS()

Sources/Swiftly/Config.swift

@@ -52,7 +52,7 @@ public struct Config: Codable, Equatable {
 
     public func listInstalledToolchains(selector: ToolchainSelector?) -> [ToolchainVersion] {
         guard let selector else {
-            return Array(self.installedToolchains)
+            return Array(self.installedToolchains) + [.xcodeVersion]
         }
 
         if case .latest = selector {
@@ -63,7 +63,7 @@ public struct Config: Codable, Equatable {
             return ts
         }
 
-        return self.installedToolchains.filter { toolchain in
+        return (self.installedToolchains + [.xcodeVersion]).filter { toolchain in
             selector.matches(toolchain: toolchain)
         }
     }

Sources/Swiftly/Install.swift

@@ -216,6 +216,8 @@ struct Install: SwiftlyCommand {
             case .main:
                 category = "development"
             }
+        case .xcode:
+            fatalError("unreachable: xcode toolchain cannot be installed with swiftly")
         }
 
         let animation = PercentProgressAnimation(
@@ -282,7 +284,7 @@ struct Install: SwiftlyCommand {
             let swiftlyBinDir = Swiftly.currentPlatform.swiftlyBinDir(ctx)
             let swiftlyBinDirContents =
                 (try? FileManager.default.contentsOfDirectory(atPath: swiftlyBinDir.path)) ?? [String]()
-            let toolchainBinDir = Swiftly.currentPlatform.findToolchainBinDir(ctx, version)
+            let toolchainBinDir = try await Swiftly.currentPlatform.findToolchainBinDir(ctx, version)
             let toolchainBinDirContents = try FileManager.default.contentsOfDirectory(
                 atPath: toolchainBinDir.path)
 
@@ -429,6 +431,8 @@ struct Install: SwiftlyCommand {
             }
 
             return .snapshot(firstSnapshot)
+        case .xcode:
+            throw SwiftlyError(message: "xcode toolchains are not available from swift.org")
         }
     }
 }

Sources/Swiftly/List.swift

@@ -97,6 +97,9 @@ struct List: SwiftlyCommand {
             for toolchain in toolchains where toolchain.isSnapshot() {
                 await printToolchain(toolchain)
             }
+
+            await ctx.print("")
+            await printToolchain(ToolchainVersion.xcode)
         }
     }
 }

Sources/Swiftly/Uninstall.swift

@@ -51,7 +51,7 @@ struct Uninstall: SwiftlyCommand {
         try validateSwiftly(ctx)
         let startingConfig = try Config.load(ctx)
 
-        let toolchains: [ToolchainVersion]
+        var toolchains: [ToolchainVersion]
         if self.toolchain == "all" {
             // Sort the uninstalled toolchains such that the in-use toolchain will be uninstalled last.
             // This avoids printing any unnecessary output from using new toolchains while the uninstall is in progress.
@@ -68,6 +68,8 @@ struct Uninstall: SwiftlyCommand {
             toolchains = installedToolchains
         }
 
+        toolchains.removeAll(where: { $0 == .xcodeVersion })
+
         guard !toolchains.isEmpty else {
             await ctx.print("No toolchains matched \"\(self.toolchain)\"")
             return
@@ -101,6 +103,9 @@ struct Uninstall: SwiftlyCommand {
                 case let .snapshot(s):
                     // If a snapshot was previously in use, switch to the latest snapshot associated with that branch.
                     selector = .snapshot(branch: s.branch, date: nil)
+                case .xcode:
+                    // Xcode will not be in the list of installed toolchains, so this is only here for completeness
+                    selector = .xcode
                 }
 
                 if let toUse = config.listInstalledToolchains(selector: selector)

Sources/Swiftly/Update.swift

@@ -195,6 +195,8 @@ struct Update: SwiftlyCommand {
             default:
                 fatalError("unreachable")
             }
+        case let .xcode:
+            throw SwiftlyError(message: "xcode cannot be updated from swiftly")
         }
     }
 

Sources/Swiftly/Use.swift

@@ -78,7 +78,7 @@ struct Use: SwiftlyCommand {
 
             if self.printLocation {
                 // Print the toolchain location and exit
-                await ctx.print("\(Swiftly.currentPlatform.findToolchainLocation(ctx, selectedVersion).path)")
+                await ctx.print("\(try await Swiftly.currentPlatform.findToolchainLocation(ctx, selectedVersion).path)")
                 return
             }
 

Sources/SwiftlyCore/Platform.swift

@@ -132,10 +132,10 @@ public protocol Platform: Sendable {
     func getShell() async throws -> String
 
     /// Find the location where the toolchain should be installed.
-    func findToolchainLocation(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) -> URL
+    func findToolchainLocation(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) async throws -> URL
 
     /// Find the location of the toolchain binaries.
-    func findToolchainBinDir(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) -> URL
+    func findToolchainBinDir(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) async throws -> URL
 }
 
 extension Platform {
@@ -164,11 +164,11 @@ extension Platform {
     }
 
 #if os(macOS) || os(Linux)
-    func proxyEnv(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) throws -> [
+    func proxyEnv(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) async throws -> [
         String:
             String
     ] {
-        let tcPath = self.findToolchainLocation(ctx, toolchain).appendingPathComponent("usr/bin")
+        let tcPath = try await self.findToolchainLocation(ctx, toolchain).appendingPathComponent("usr/bin")
         guard tcPath.fileExists() else {
             throw SwiftlyError(
                 message:
@@ -196,7 +196,7 @@ extension Platform {
         _ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion, _ command: String,
         _ arguments: [String], _ env: [String: String] = [:]
     ) async throws {
-        var newEnv = try self.proxyEnv(ctx, toolchain)
+        var newEnv = try await self.proxyEnv(ctx, toolchain)
         for (key, value) in env {
             newEnv[key] = value
         }
@@ -436,9 +436,9 @@ extension Platform {
         return FileManager.default.fileExists(atPath: swiftlyHomeBin) ? swiftlyHomeBin : nil
     }
 
-    public func findToolchainBinDir(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) -> URL
+    public func findToolchainBinDir(_ ctx: SwiftlyCoreContext, _ toolchain: ToolchainVersion) async throws -> URL
     {
-        self.findToolchainLocation(ctx, toolchain).appendingPathComponent("usr/bin")
+        try await self.findToolchainLocation(ctx, toolchain).appendingPathComponent("usr/bin")
     }
 
 #endif

Sources/SwiftlyCore/ToolchainVersion.swift

@@ -90,6 +90,7 @@ public enum ToolchainVersion: Sendable {
 
     case stable(StableRelease)
     case snapshot(Snapshot)
+    case xcode
 
     public init(major: Int, minor: Int, patch: Int) {
         self = .stable(StableRelease(major: major, minor: minor, patch: patch))
@@ -99,6 +100,8 @@ public enum ToolchainVersion: Sendable {
         self = .snapshot(Snapshot(branch: snapshotBranch, date: date))
     }
 
+    public static let xcodeVersion: ToolchainVersion = .xcode
+
     static func stableRegex() -> Regex<(Substring, Substring, Substring, Substring)> {
         try! Regex("^(?:Swift )?(\\d+)\\.(\\d+)\\.(\\d+)$")
     }
@@ -132,6 +135,8 @@ public enum ToolchainVersion: Sendable {
                 throw SwiftlyError(message: "invalid release snapshot version: \(string)")
             }
             self = ToolchainVersion(snapshotBranch: .release(major: major, minor: minor), date: String(match.output.3))
+        } else if string == "xcode" {
+            self = ToolchainVersion.xcodeVersion
         } else {
             throw SwiftlyError(message: "invalid toolchain version: \"\(string)\"")
         }
@@ -176,6 +181,8 @@ public enum ToolchainVersion: Sendable {
             case let .release(major, minor):
                 return "\(major).\(minor)-snapshot-\(release.date)"
             }
+        case .xcode:
+            return "xcode"
         }
     }
 
@@ -194,6 +201,8 @@ public enum ToolchainVersion: Sendable {
             case let .release(major, minor):
                 return "swift-\(major).\(minor)-DEVELOPMENT-SNAPSHOT-\(release.date)-a"
             }
+        case .xcode:
+            return "xcode"
         }
     }
 }
@@ -214,6 +223,8 @@ extension ToolchainVersion: CustomStringConvertible {
             return "\(release)"
         case let .snapshot(snapshot):
             return "\(snapshot)"
+        case .xcode:
+            return "xcode"
         }
     }
 }
@@ -231,6 +242,10 @@ extension ToolchainVersion: Comparable {
             return false
         case (.stable, .snapshot):
             return !(rhs < lhs)
+        case (.xcode, .xcode):
+            return true
+        default:
+            return false
         }
     }
 }
@@ -254,6 +269,9 @@ public enum ToolchainSelector: Sendable {
     /// associated with the given branch.
     case snapshot(branch: ToolchainVersion.Snapshot.Branch, date: String?)
 
+    /// Selects the Xcode of the current system.
+    case xcode
+
     public init(major: Int, minor: Int? = nil, patch: Int? = nil) {
         self = .stable(major: major, minor: minor, patch: patch)
     }
@@ -267,14 +285,19 @@ public enum ToolchainSelector: Sendable {
             return
         }
 
+        if input == "xcode" {
+            self = Self.xcode
+            return
+        }
+
         throw SwiftlyError(message: "invalid toolchain selector: \"\(input)\"")
     }
 
     public func isReleaseSelector() -> Bool {
         switch self {
         case .latest, .stable:
             return true
-        case .snapshot:
+        default:
             return false
         }
     }
@@ -312,7 +335,8 @@ public enum ToolchainSelector: Sendable {
                 }
             }
             return true
-
+        case (.xcode, .xcode):
+            return true
         default:
             return false
         }
@@ -341,6 +365,8 @@ extension ToolchainSelector: CustomStringConvertible {
                 s += "-\(date)"
             }
             return s
+        case .xcode:
+            return "xcode"
         }
     }
 }

Tests/SwiftlyTests/UseTests.swift

@@ -202,7 +202,9 @@ import Testing
 
                 output = try await SwiftlyTests.runWithMockedIO(Use.self, ["use", "-g", "--print-location"])
 
-                #expect(output.contains(where: { $0.contains(Swiftly.currentPlatform.findToolchainLocation(SwiftlyTests.ctx, toolchain).path) }))
+                let location = try await Swiftly.currentPlatform.findToolchainLocation(SwiftlyTests.ctx, toolchain).path
+
+                #expect(output.contains(where: { $0.contains(location) }))
             }
         }
     }