Improve JSON progress file handling and error reporting

Author: roulpriya

Sources/SwiftlyCore/FileManager+FilePath.swift

@@ -195,15 +195,6 @@ extension String {
             try self.write(to: path, atomically: true, encoding: enc)
             return
         }
-
-        let fileHandle = try FileHandle(forWritingTo: URL(fileURLWithPath: path.string))
-        defer { fileHandle.closeFile() }
-        fileHandle.seekToEndOfFile()
-        if let data = self.data(using: enc) {
-            fileHandle.write(data)
-        } else {
-            throw SwiftlyError(message: "Failed to convert string to data with encoding \(enc)")
-        }
     }
 
     public init(contentsOf path: FilePath, encoding enc: String.Encoding = .utf8) throws {

Tests/SwiftlyTests/JsonFileProgressReporterTests.swift

@@ -1,6 +1,4 @@
 import Foundation
-@testable import Swiftly
-@testable import SwiftlyCore
 import SystemPackage
 import Testing
 
@@ -102,18 +100,21 @@ import Testing
         try FileManager.default.removeItem(atPath: tempFile.string)
     }
 
-    @Test("Test clear method removes file")
-    func testClearRemovesFile() throws {
+    @Test("Test clear method truncates the file")
+    func testClearTruncatesFile() async throws {
         let tempFile = fs.mktemp(ext: ".json")
-        let reporter = JsonFileProgressReporter(filePath: tempFile)
+        try await fs.create(.mode(Int(0o644)), file: tempFile)
+        defer { try? FileManager.default.removeItem(atPath: tempFile.string) }
+        let reporter = try JsonFileProgressReporter(SwiftlyTests.ctx, filePath: tempFile)
+        defer { try? reporter.close() }
 
         reporter.update(step: 1, total: 2, text: "Test")
 
-        #expect(FileManager.default.fileExists(atPath: tempFile.string))
+        #expect(try String(contentsOf: tempFile).lengthOfBytes(using: String.Encoding.utf8) > 0)
 
         reporter.clear()
 
-        #expect(!FileManager.default.fileExists(atPath: tempFile.string))
+        #expect(try String(contentsOf: tempFile).lengthOfBytes(using: String.Encoding.utf8) == 0)
     }
 
     @Test("Test multiple progress updates create multiple lines")
@@ -129,8 +130,6 @@ import Testing
         reporter.update(step: 50, total: 100, text: "Processing item 50")
         reporter.update(step: 100, total: 100, text: "Processing item 100")
 
-        reporter.update(step: 1, total: 3, text: "Step 1")
-        reporter.update(step: 2, total: 3, text: "Step 2")
         reporter.complete(success: true)
         try? reporter.close()