Code review feedback

Author: cmcgee1024

Sources/SwiftlyCore/Commands.swift

@@ -1,8 +1,13 @@
 import Foundation
 import SystemPackage
 
+public enum SystemCommand {}
+
+// This file contains a set of system commands that's used by Swiftly and its related tests and tooling
+
 // Directory Service command line utility for macOS
-public enum SystemCommand {
+// See dscl(1) for details
+extension SystemCommand {
     public static func dscl(executable: Executable = DsclCommand.defaultExecutable, datasource: String? = nil) -> DsclCommand {
         DsclCommand(executable: executable, datasource: datasource)
     }
@@ -30,7 +35,7 @@ public enum SystemCommand {
 
             return Configuration(
                 executable: self.executable,
-                arguments: .init(args),
+                arguments: Arguments(args),
                 environment: .inherit
             )
         }

Sources/SwiftlyCore/ModeledCommandLine.swift

@@ -121,27 +121,6 @@ public struct Arguments: Sendable, ExpressibleByArrayLiteral, Hashable {
     }
 }
 
-extension Executable {
-    public func exists() async throws -> Bool {
-        switch self.storage {
-        case let .path(p):
-            return (try await FileSystem.exists(atPath: p))
-        case let .executable(e):
-            let path = ProcessInfo.processInfo.environment["PATH"]
-
-            guard let path else { return false }
-
-            for p in path.split(separator: ":") {
-                if try await FileSystem.exists(atPath: FilePath(String(p)) / e) {
-                    return true
-                }
-            }
-
-            return false
-        }
-    }
-}
-
 public protocol Runnable {
     func config() -> Configuration
 }

Tests/SwiftlyTests/SwiftlyTests.swift

@@ -25,6 +25,27 @@ extension Tag {
     @Tag static var large: Self
 }
 
+extension Executable {
+    public func exists() async throws -> Bool {
+        switch self.storage {
+        case let .path(p):
+            return (try await FileSystem.exists(atPath: p))
+        case let .executable(e):
+            let path = ProcessInfo.processInfo.environment["PATH"]
+
+            guard let path else { return false }
+
+            for p in path.split(separator: ":") {
+                if try await FileSystem.exists(atPath: FilePath(String(p)) / e) {
+                    return true
+                }
+            }
+
+            return false
+        }
+    }
+}
+
 let unmockedMsg = "All swiftly test case logic must be mocked in order to prevent mutation of the system running the test. This test must either run swiftly components inside a SwiftlyTests.with... closure, or it must have one of the @Test traits, such as @Test(.testHome), or @Test(.mock...)"
 
 actor OutputHandlerFail: OutputHandler {