Testing: withMockedHome: Forward errors from function under test
#424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was silently swallowing errors coming from the function under test, so errors in the tests did not surface as test failures. This throws the error if the cleaning the bin directory doesn't fail first.
Now that the mock home directory isn't swallowing function errors, these are resulting in test failures when they aren't actually intended. In these cases, we use `#expect` to verify the version, but swallow any errors returned by the swiftly invocation. In all cases, these were the result of trying to switch to a toolchain that didn't exist. This should emit an error message, but leave the selected toolchain unchanged.
etcwilde
requested review from
cmcgee1024,
justice-adams-apple and
shahmishal
as code owners
|
praise: great catch! |
cmcgee1024
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withMockedHomefunction was swallowing errors from the function under test. This meant that invocations of Swiftly that should have resulted in a test failure would silently pass. e.g.swiftly uninstall 1.2.4 4.5.6as a test case would pass, even though Swiftly was emitting an error.There were a couple of cases where this behavior was being relied on for the UseTests to verify that switching to a non-existent toolchain version wouldn't change things from the selected version. In those cases, we want to swallow the error.