Skip to content

Commit 20b4baf

Browse files
authored
Fix withKnownIssue not marking test as skipped in nightly toolchains (#1838)
With the introduction of issue severity, the issue payload contains the flag `isFailure`. If this is true, we were assuming that the issue didn't meet the severity threshold. However if an issue is skipped with `withKnownIssue`, `isFailure` would be false but `isKnown` is true. In this case we still want to record the issue and have the test be marked as skipped.
1 parent f9fd9be commit 20b4baf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/TestExplorer/TestParsers/SwiftTestingOutputParser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ export class SwiftTestingOutputParser {
381381
.map(message => MessageRenderer.render(message))
382382
.join("\n");
383383

384-
if (payload.issue.isFailure === false) {
384+
if (payload.issue.isFailure === false && !payload.issue.isKnown) {
385385
return;
386386
}
387387

0 commit comments

Comments
 (0)