Skip to content

Commit 5bb7a2d

Browse files
authored
Issue vscode-swift#1173:Update NodeJs 20 and vsce 3 (#1436)
1 parent 0fc9512 commit 5bb7a2d

File tree

9 files changed

+289
-113
lines changed

9 files changed

+289
-113
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ RUN export DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true \
1313

1414
RUN mkdir -p /usr/local/nvm
1515
ENV NVM_DIR /usr/local/nvm
16-
ENV NODE_VERSION v18.19.0
16+
ENV NODE_VERSION v20.18.2
1717
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
1818
RUN /bin/bash -c "source $NVM_DIR/nvm.sh && nvm install $NODE_VERSION"
1919
ENV NODE_PATH $NVM_DIR/versions/node/$NODE_VERSION/bin

.github/workflows/nightly.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
uses: actions/checkout@v4
1717
- name: Build Extension
1818
run: |
19-
export NODE_VERSION=v18.19.0
20-
export NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
19+
export NODE_VERSION=v20.18.2
20+
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
2121
export NVM_DIR=/usr/local/nvm
2222
. .github/workflows/scripts/setup-linux.sh
2323
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
@@ -37,8 +37,8 @@ jobs:
3737
with:
3838
# Linux
3939
linux_env_vars: |
40-
NODE_VERSION=v18.19.0
41-
NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
40+
NODE_VERSION=v20.18.2
41+
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
4242
NVM_DIR=/usr/local/nvm
4343
CI=1
4444
linux_pre_build_command: . .github/workflows/scripts/setup-linux.sh
@@ -58,8 +58,8 @@ jobs:
5858
# Linux
5959
linux_exclude_swift_versions: '[{"swift_version": "5.8"}, {"swift_version": "5.9"}, {"swift_version": "5.10"}, {"swift_version": "nightly-6.1"}, {"swift_version": "nightly-main"}]'
6060
linux_env_vars: |
61-
NODE_VERSION=v18.19.0
62-
NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
61+
NODE_VERSION=v20.18.2
62+
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
6363
NVM_DIR=/usr/local/nvm
6464
CI=1
6565
VSCODE_TEST=1

.github/workflows/pull_request.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ jobs:
1212
# Linux
1313
linux_exclude_swift_versions: '[{"swift_version": "nightly-6.1"},{"swift_version": "nightly-main"}]'
1414
linux_env_vars: |
15-
NODE_VERSION=v18.19.0
16-
NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
15+
NODE_VERSION=v20.18.2
16+
NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
1717
NVM_DIR=/usr/local/nvm
1818
CI=1
1919
VSCODE_TEST=1

.github/workflows/scripts/setup-linux.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
##
1414
##===----------------------------------------------------------------------===##
1515

16-
export NODE_VERSION=v18.19.0
17-
export NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
16+
export NODE_VERSION=v20.18.2
17+
export NODE_PATH=/usr/local/nvm/versions/node/v20.18.2/bin
1818
export NVM_DIR=/usr/local/nvm
1919

2020
apt-get update && apt-get install -y rsync curl gpg libasound2 libgbm1 libgtk-3-0 libnss3 xvfb build-essential

.github/workflows/scripts/windows/install-nodejs.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
$NODEJS='https://nodejs.org/dist/v18.20.4/node-v18.20.4-x64.msi'
1+
$NODEJS='https://nodejs.org/dist/v20.18.2/node-v20.18.2-x64.msi'
22
$NODEJS_SHA256='c2654d3557abd59de08474c6dd009b1d358f420b8e4010e4debbf130b1dfb90a'
33
Set-Variable ErrorActionPreference Stop
44
Set-Variable ProgressPreference SilentlyContinue

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.19.0
1+
20.18.2

0 commit comments

Comments
 (0)