Validation: Push value on local.tee even if the frame is unreachable

kateinoigakukun · kateinoigakukun · commit 0a9fa7bec0fa · 2024-10-07T02:27:33.000+09:00
diff --git a/Sources/WasmKit/Translator.swift b/Sources/WasmKit/Translator.swift
@@ -1577,7 +1577,6 @@ struct InstructionTranslator<Context: TranslatorContext>: InstructionVisitor {
         try visitLocalSetOrTee(localIndex: localIndex, isTee: false)
     }
     mutating func visitLocalTee(localIndex: UInt32) throws -> Output {
-        guard try controlStack.currentFrame().reachable else { return }
         try visitLocalSetOrTee(localIndex: localIndex, isTee: true)
         _ = try valueStack.pushLocal(localIndex, locals: &locals)
     }

Original file line number	Diff line number	Diff line change
`@@ -1577,7 +1577,6 @@ struct InstructionTranslator<Context: TranslatorContext>: InstructionVisitor {`
`1577`	`1577`	`try visitLocalSetOrTee(localIndex: localIndex, isTee: false)`
`1578`	`1578`	`}`
`1579`	`1579`	`mutating func visitLocalTee(localIndex: UInt32) throws -> Output {`
`1580`		`- guard try controlStack.currentFrame().reachable else { return }`
`1581`	`1580`	`try visitLocalSetOrTee(localIndex: localIndex, isTee: true)`
`1582`	`1581`	`_ = try valueStack.pushLocal(localIndex, locals: &locals)`
`1583`	`1582`	`}`