Handle qThreadStopInfo, run up to breakpoint in handler

Author: MaxDesiatov

Sources/GDBRemoteProtocol/GDBHostCommand.swift

@@ -38,6 +38,7 @@ package struct GDBHostCommand: Equatable {
         case readMemoryBinaryData
         case readMemory
         case wasmCallStack
+        case threadStopInfo
 
         case generalRegisters
 
@@ -97,6 +98,7 @@ package struct GDBHostCommand: Equatable {
     ///   - arguments: raw arguments that immediately follow kind of the command.
     package init(kindString: String, arguments: String) throws(GDBHostCommandDecoder.Error) {
         let registerInfoPrefix = "qRegisterInfo"
+        let threadStopInfoPrefix = "qThreadStopInfo"
 
         if kindString.starts(with: "x") {
             self.kind = .readMemoryBinaryData
@@ -109,6 +111,14 @@ package struct GDBHostCommand: Equatable {
         } else if kindString.starts(with: registerInfoPrefix) {
             self.kind = .registerInfo
 
+            guard arguments.isEmpty else {
+                throw GDBHostCommandDecoder.Error.unexpectedArgumentsValue
+            }
+            self.arguments = String(kindString.dropFirst(registerInfoPrefix.count))
+            return
+        } else if kindString.starts(with: threadStopInfoPrefix) {
+            self.kind = .threadStopInfo
+
             guard arguments.isEmpty else {
                 throw GDBHostCommandDecoder.Error.unexpectedArgumentsValue
             }

Sources/GDBRemoteProtocol/GDBTargetResponseEncoder.swift

@@ -11,6 +11,7 @@
 //===----------------------------------------------------------------------===//
 
 import Foundation
+import Logging
 import NIOCore
 
 extension String {
@@ -27,7 +28,12 @@ extension String {
 package class GDBTargetResponseEncoder: MessageToByteEncoder {
     private var isNoAckModeActive = false
 
-    package init() {}
+    private let logger: Logger
+
+    package init(logger: Logger) {
+        self.logger = logger
+    }
+
     package func encode(data: GDBTargetResponse, out: inout ByteBuffer) {
         if !isNoAckModeActive {
             out.writeInteger(UInt8(ascii: "+"))
@@ -51,8 +57,9 @@ package class GDBTargetResponseEncoder: MessageToByteEncoder {
             out.writeString(str.appendedChecksum)
 
         case .hexEncodedBinary(let binary):
-            let hexDump = ByteBuffer(bytes: binary).hexDump(format: .compact)
-            out.writeString(hexDump.appendedChecksum)
+            let hexDumpResponse = ByteBuffer(bytes: binary).hexDump(format: .compact).appendedChecksum
+            self.logger.trace("GDBTargetResponseEncoder encoded a response", metadata: ["RawResponse": .string(hexDumpResponse)])
+            out.writeString(hexDumpResponse)
 
         case .empty:
             out.writeString("".appendedChecksum)

Sources/WasmKitGDBHandler/WasmKitGDBHandler.swift

@@ -38,6 +38,7 @@
         enum Error: Swift.Error {
             case unknownTransferArguments
             case unknownReadMemoryArguments
+            case stoppingAtEntrypointFailed
         }
 
         private let wasmBinary: ByteBuffer
@@ -63,6 +64,9 @@
 
             self.debugger = try Debugger(module: parseWasm(bytes: .init(buffer: self.wasmBinary)), store: store, imports: imports)
             try self.debugger.stopAtEntrypoint()
+            guard try self.debugger.run() == nil else {
+                throw Error.stoppingAtEntrypointFailed
+            }
         }
 
         package func handle(command: GDBHostCommand) throws -> GDBTargetResponse {
@@ -114,7 +118,7 @@
             case .subsequentThreadInfo:
                 responseKind = .string("l")
 
-            case .targetStatus:
+            case .targetStatus, .threadStopInfo:
                 responseKind = .keyValuePairs([
                     "T05thread": "1",
                     "reason": "trace",