Validation: Check for duplicate export names

kateinoigakukun · kateinoigakukun · commit 9ae4b3437866 · 2024-10-04T12:57:56.000+09:00
diff --git a/Sources/WasmKit/Execution/StoreAllocator.swift b/Sources/WasmKit/Execution/StoreAllocator.swift
@@ -429,6 +429,9 @@ extension StoreAllocator {
         }
 
         let exports: [String: InternalExternalValue] = try module.exports.reduce(into: [:]) { result, export in
+            guard result[export.name] == nil else {
+                throw ValidationError("Duplicate export name: \(export.name)")
+            }
             result[export.name] = try createExportValue(export)
         }
 
diff --git a/Tests/WasmKitTests/SpectestTests.swift b/Tests/WasmKitTests/SpectestTests.swift
@@ -22,7 +22,6 @@ final class SpectestTests: XCTestCase {
             path: Self.testPaths,
             include: [],
             exclude: [
-                "exports.wast",
                 "func.wast",
                 "func_ptrs.wast",
                 "global.wast",

Original file line number	Diff line number	Diff line change
`@@ -429,6 +429,9 @@ extension StoreAllocator {`
`429`	`429`	`}`
`430`	`430`
`431`	`431`	`let exports: [String: InternalExternalValue] = try module.exports.reduce(into: [:]) { result, export in`
	`432`	`+ guard result[export.name] == nil else {`
	`433`	`+ throw ValidationError("Duplicate export name: \(export.name)")`
	`434`	`+ }`
`432`	`435`	`result[export.name] = try createExportValue(export)`
`433`	`436`	`}`
`434`	`437`