WAT: Ban multiple start sections

kateinoigakukun · kateinoigakukun · commit a8e5ddd65d1f · 2024-10-03T09:38:05.000+09:00
diff --git a/Sources/WAT/WAT.swift b/Sources/WAT/WAT.swift
@@ -258,6 +258,9 @@ func parseWAT(_ parser: inout Parser, features: WasmFeatureSet) throws -> Wat {
         case let .data(decl):
             try dataSegmentsMap.add(decl)
         case let .start(startIndex):
+            guard start == nil else {
+                throw WatParserError("Multiple start sections", location: location)
+            }
             start = startIndex
         }
     }
diff --git a/Tests/WATTests/EncoderTests.swift b/Tests/WATTests/EncoderTests.swift
@@ -107,7 +107,6 @@ class EncoderTests: XCTestCase {
 
             var stats = CompatibilityTestStats()
             let excluded: [String] = [
-                "start.wast",
                 "token.wast",
                 "utf8-invalid-encoding.wast"
             ]

Original file line number	Diff line number	Diff line change
`@@ -258,6 +258,9 @@ func parseWAT(_ parser: inout Parser, features: WasmFeatureSet) throws -> Wat {`
`258`	`258`	`case let .data(decl):`
`259`	`259`	`try dataSegmentsMap.add(decl)`
`260`	`260`	`case let .start(startIndex):`
	`261`	`+ guard start == nil else {`
	`262`	`+ throw WatParserError("Multiple start sections", location: location)`
	`263`	`+ }`
`261`	`264`	`start = startIndex`
`262`	`265`	`}`
`263`	`266`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,6 @@ class EncoderTests: XCTestCase {`
`107`	`107`
`108`	`108`	`var stats = CompatibilityTestStats()`
`109`	`109`	`let excluded: [String] = [`
`110`		`- "start.wast",`
`111`	`110`	`"token.wast",`
`112`	`111`	`"utf8-invalid-encoding.wast"`
`113`	`112`	`]`