Skip to content

Commit 002c6d1

Browse files
committed
[CS] Remove some calls to setExprTypes
`rewriteTarget` already calls `setExprTypes` for expressions, so these are redundant.
1 parent 6c92f3f commit 002c6d1

File tree

2 files changed

+0
-31
lines changed

2 files changed

+0
-31
lines changed

lib/Sema/CSApply.cpp

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -8858,11 +8858,6 @@ namespace {
88588858
hadError |= cs.applySolutionToBody(
88598859
solution, closure, Rewriter.dc, [&](SyntacticElementTarget target) {
88608860
auto resultTarget = rewriteTarget(target);
8861-
if (resultTarget) {
8862-
if (auto expr = resultTarget->getAsExpr())
8863-
solution.setExprTypes(expr);
8864-
}
8865-
88668861
return resultTarget;
88678862
});
88688863

@@ -8946,11 +8941,6 @@ namespace {
89468941
Rewriter.solution, fn, Rewriter.dc,
89478942
[&](SyntacticElementTarget target) {
89488943
auto resultTarget = rewriteTarget(target);
8949-
if (resultTarget) {
8950-
if (auto expr = resultTarget->getAsExpr())
8951-
Rewriter.solution.setExprTypes(expr);
8952-
}
8953-
89548944
return resultTarget;
89558945
});
89568946

@@ -8983,12 +8973,6 @@ namespace {
89838973
return Rewriter.cs.applySolutionToSingleValueStmt(
89848974
solution, SVE, solution.getDC(), [&](SyntacticElementTarget target) {
89858975
auto resultTarget = rewriteTarget(target);
8986-
if (!resultTarget)
8987-
return resultTarget;
8988-
8989-
if (auto expr = resultTarget->getAsExpr())
8990-
solution.setExprTypes(expr);
8991-
89928976
return resultTarget;
89938977
});
89948978
}
@@ -9004,11 +8988,6 @@ namespace {
90048988
(void)Rewriter.cs.applySolutionToBody(
90058989
solution, tap, Rewriter.dc, [&](SyntacticElementTarget target) {
90068990
auto resultTarget = rewriteTarget(target);
9007-
if (resultTarget) {
9008-
if (auto expr = resultTarget->getAsExpr())
9009-
solution.setExprTypes(expr);
9010-
}
9011-
90128991
return resultTarget;
90138992
});
90148993
}
@@ -9779,11 +9758,6 @@ ExprWalker::rewriteTarget(SyntacticElementTarget target) {
97799758
auto forEachResultTarget = applySolutionToForEachStmt(
97809759
solution, target, [&](SyntacticElementTarget target) {
97819760
auto resultTarget = rewriteTarget(target);
9782-
if (resultTarget) {
9783-
if (auto expr = resultTarget->getAsExpr())
9784-
solution.setExprTypes(expr);
9785-
}
9786-
97879761
return resultTarget;
97889762
});
97899763
if (!forEachResultTarget)

lib/Sema/CSSyntacticElement.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2267,11 +2267,6 @@ class ResultBuilderRewriter : public SyntacticElementSolutionApplication {
22672267
assert(funcRef);
22682268

22692269
funcRef->setTypecheckedBody(castToStmt<BraceStmt>(body));
2270-
2271-
if (auto *closure =
2272-
getAsExpr<ClosureExpr>(funcRef->getAbstractClosureExpr()))
2273-
solution.setExprTypes(closure);
2274-
22752270
return false;
22762271
}
22772272

0 commit comments

Comments
 (0)