[Optimizer] Don't walk to deleted.

During inlining, some instructions in the caller may be deleted.  So
when publishing this best effort list of instructions which were
"changed" during inlining, don't start from a deleted instruction.
Instead just don't publish, as already happens in other cases.

Without actually addressing
```
// TODO: get a list of cloned instructions from the `inlineFunction`
```
this is somewhat better than checking for having reached the end of the
function during the walk because that will result in falsely
broadcasting that some unchanged instructions have changed whereas this
change only results in not broadcasting which is already being done in
some cases (e.g. when a `begin_apply` is immediately followed by an
`end_apply`).

Author: nate-chandler

SwiftCompilerSources/Sources/Optimizer/PassManager/ContextCommon.swift

@@ -113,7 +113,8 @@ extension MutatingContext {
     bridgedPassContext.inlineFunction(apply.bridged, mandatoryInline)
 
     if let instBeforeInlining = instBeforeInlining?.next,
-       let instAfterInlining = instAfterInlining {
+       let instAfterInlining = instAfterInlining,
+       !instAfterInlining.isDeleted {
       notifyNewInstructions(from: instBeforeInlining, to: instAfterInlining)
     }
   }

validation-test/SILOptimizer/rdar161433604.swift

@@ -10,8 +10,6 @@
 // REQUIRES: swift_feature_Embedded
 // REQUIRES: swift_feature_LifetimeDependence
 
-// XFAIL: *
-
 struct NoEscapeNoCopy: ~Escapable, ~Copyable {}
 
 protocol Foo {