SILParser: don't accept instructions after "unreachable"

All instructions after an "unreachable" were not added to the function anyway and were leaking.

Author: eeckstein

lib/SIL/Parser/ParseSIL.cpp

@@ -5277,6 +5277,11 @@ bool SILParser::parseSILInstruction(SILBuilder &B) {
     return true;
   }
 
+  if (!B.hasValidInsertionPoint()) {
+    P.diagnose(P.Tok, diag::expected_sil_block_name);
+    return true;
+  }
+
   SmallVector<Located<StringRef>, 4> resultNames;
   SourceLoc resultClauseBegin;
 

test/SIL/Parser/errors.sil

@@ -56,3 +56,11 @@ sil @test_formal_substituted_type : $@convention(thin) <X> (@owned Array<@substi
 entry(%0 : $Array<X>):
   return undef : $()
 }
+
+sil @instructions_after_terminator : $@convention(thin) () -> () {
+bb0:
+  unreachable
+  %0 = tuple () // expected-error {{expected basic block name or '}'}}
+  return %0 : $()
+}
+

test/SILOptimizer/sil_combine.sil

@@ -2413,19 +2413,6 @@ bb0:
 }
 
 
-// CHECK-LABEL:   sil @remove_dead_code_after_unreachable
-// CHECK-NEXT:      bb0
-// CHECK-NEXT:      unreachable
-// CHECK-NEXT:      } // end sil function 'remove_dead_code_after_unreachable'
-sil @remove_dead_code_after_unreachable : $@convention(thin) () -> (Int32) {
-bb0:
-  unreachable
-  %2 = integer_literal $Builtin.Int32, -2
-  %3 = struct $Int32 (%2 : $Builtin.Int32)
-  return %3 : $Int32
-}
-
-
 // CHECK-LABEL:   sil @dont_remove_code_after_cond_fail
 // CHECK:         bb0([[Cond:%.*]] : $Builtin.Int1):
 // CHECK-NEXT:      [[Ref:%.*]] = integer_literal $Builtin.Int32, -2