[Distributed] introduce GenDistributed.h/cpp for code organization

Author: ktoso

lib/AST/Builtins.cpp

@@ -1467,20 +1467,13 @@ static ValueDecl *getDistributedActorInitializeRemote(ASTContext &ctx,
   return getBuiltinFunction(ctx, id, _thin,
                             _generics(_unrestricted), // TODO(distributed): restrict to DistributedActor
                             _parameters(_metatype(_typeparam(0))),
-//                            _parameters(_nativeObject),
                             _rawPointer);
-
-//  return getBuiltinFunction(ctx, id, _thin,
-//                            _generics(_unrestricted), // TODO(distributed): restrict to DistributedActor
-//                            _parameters(_metatype(_typeparam(0))),
-// //                            _parameters(_nativeObject),
-//                            _rawPointer);
 }
 
 static ValueDecl *getDistributedActorDestroy(ASTContext &ctx,
                                                  Identifier id) {
   return getBuiltinFunction(ctx, id, _thin,
-                            _parameters(_nativeObject), // TODO: no idea if to pass more here?
+                            _parameters(_nativeObject),
                             _void);
 }
 

lib/IRGen/CMakeLists.txt

@@ -17,6 +17,7 @@ add_swift_host_library(swiftIRGen STATIC
   GenControl.cpp
   GenCoverage.cpp
   GenConcurrency.cpp
+  GenDistributed.cpp
   GenDecl.cpp
   GenDiffFunc.cpp
   GenDiffWitness.cpp

lib/IRGen/GenBuiltin.cpp

@@ -29,6 +29,7 @@
 #include "GenCall.h"
 #include "GenCast.h"
 #include "GenConcurrency.h"
+#include "GenDistributed.h"
 #include "GenPointerAuth.h"
 #include "GenIntegerLiteral.h"
 #include "IRGenFunction.h"
@@ -388,34 +389,14 @@ void irgen::emitBuiltinCall(IRGenFunction &IGF, const BuiltinInfo &Builtin,
   }
 
   if (Builtin.ID == BuiltinValueKind::InitializeDistributedRemoteActor) {
-    auto fn = IGF.IGM.getDistributedActorInitializeRemoteFn();
-    auto actorTy = args.claimNext();
-    fprintf(stderr, "[%s:%d] (%s) ARGUMENT ONE\n", __FILE__, __LINE__, __FUNCTION__);
-    actorTy->dump();
-    fprintf(stderr, "[%s:%d] (%s) ARGUMENT ONE CAST\n", __FILE__, __LINE__, __FUNCTION__);
-    actorTy = IGF.Builder.CreateBitCast(actorTy, IGF.IGM.TypeMetadataPtrTy);
-    actorTy->dump();
-    auto call = IGF.Builder.CreateCall(fn, { actorTy });
-    call->setCallingConv(IGF.IGM.SwiftCC);
-    call->setDoesNotThrow();
-    fprintf(stderr, "[%s:%d] (%s) CALL\n", __FILE__, __LINE__, __FUNCTION__);
-    call->dump();
-
-    // Cast back to opaque value
-//    auto result = IGF.Builder.CreateBitCast(call, IGF.IGM.OpaquePtrTy);
-//    out.add(result);
-    out.add(call);
-
+    auto actorMetatype = args.claimNext();
+    emitDistributedActorInitializeRemote(IGF, actorMetatype, out);
     return;
   }
 
   if (Builtin.ID == BuiltinValueKind::DestroyDistributedActor) {
-    auto fn = IGF.IGM.getDistributedActorDestroyFn();
     auto actor = args.claimNext();
-    actor = IGF.Builder.CreateBitCast(actor, IGF.IGM.RefCountedPtrTy);
-    auto call = IGF.Builder.CreateCall(fn, {actor});
-    call->setCallingConv(IGF.IGM.SwiftCC);
-    call->setDoesNotThrow();
+    emitDistributedActorDestroy(IGF, actor);
     return;
   }
 

lib/IRGen/GenDistributed.cpp

@@ -0,0 +1,59 @@
+//===--- GenDistributed.cpp - IRGen for distributed features --------------===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2020 - 2021 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+//
+//  This file implements IR generation for distributed features.
+//
+//===----------------------------------------------------------------------===//
+
+#include "GenDistributed.h"
+
+#include "BitPatternBuilder.h"
+#include "ExtraInhabitants.h"
+#include "GenProto.h"
+#include "GenType.h"
+#include "IRGenDebugInfo.h"
+#include "IRGenFunction.h"
+#include "IRGenModule.h"
+#include "LoadableTypeInfo.h"
+#include "ScalarPairTypeInfo.h"
+#include "swift/AST/ProtocolConformanceRef.h"
+#include "swift/ABI/MetadataValues.h"
+
+using namespace swift;
+using namespace irgen;
+
+namespace {} // end anonymous namespace
+
+llvm::Value *irgen::emitDistributedActorInitializeRemote(
+    IRGenFunction &IGF, llvm::Value *actorMetatype, Explosion &out) {
+  auto fn = IGF.IGM.getDistributedActorInitializeRemoteFn();
+  actorMetatype =
+      IGF.Builder.CreateBitCast(actorMetatype, IGF.IGM.TypeMetadataPtrTy);
+
+  auto call = IGF.Builder.CreateCall(fn, {actorMetatype});
+  call->setCallingConv(IGF.IGM.SwiftCC);
+  call->setDoesNotThrow();
+
+  out.add(call);
+
+  return call;
+}
+
+void irgen::emitDistributedActorDestroy(IRGenFunction &IGF,
+                                                 llvm::Value *actor) {
+  auto fn = IGF.IGM.getDistributedActorDestroyFn();
+  actor = IGF.Builder.CreateBitCast(actor, IGF.IGM.RefCountedPtrTy);
+
+  auto call = IGF.Builder.CreateCall(fn, {actor});
+  call->setCallingConv(IGF.IGM.SwiftCC);
+  call->setDoesNotThrow();
+}

lib/IRGen/GenDistributed.h

@@ -0,0 +1,58 @@
+//===--- GenDistributed.h - IRGen for distributed features ------*- C++ -*-===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2020 - 2021 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+//
+// This file defines interfaces for emitting code for various distributed
+// features.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef SWIFT_IRGEN_GENDISTRIBUTED_H
+#define SWIFT_IRGEN_GENDISTRIBUTED_H
+
+#include "swift/AST/Types.h"
+#include "swift/Basic/LLVM.h"
+#include "swift/SIL/ApplySite.h"
+#include "llvm/IR/CallingConv.h"
+
+#include "Callee.h"
+#include "GenHeap.h"
+#include "IRGenModule.h"
+
+namespace llvm {
+class Value;
+}
+
+namespace swift {
+class CanType;
+class ProtocolConformanceRef;
+class SILType;
+
+namespace irgen {
+class Explosion;
+class IRGenFunction;
+
+/// Emit the '_distributedActorRemoteInitialize' call.
+llvm::Value *emitDistributedActorInitializeRemote(
+    IRGenFunction &IGF,
+    llvm::Value *actorMetatype,
+    Explosion &out);
+
+/// Destroy the distributed actor.
+/// E.g. a remote actor has to be destroyed differently from a local one.
+void emitDistributedActorDestroy(
+    IRGenFunction &IGF,
+    llvm::Value *actor);
+
+} // end namespace irgen
+} // end namespace swift
+
+#endif