Skip to content

Commit 0cfe58c

Browse files
committed
[region-isolation] Mark all assign_* variants as asserting since they should be eliminated by DI before we run.
1 parent 3cacb1f commit 0cfe58c

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

lib/SILOptimizer/Analysis/RegionAnalysis.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2444,9 +2444,6 @@ CONSTANT_TRANSLATION(UnmanagedReleaseValueInst, Unhandled)
24442444
CONSTANT_TRANSLATION(UnmanagedAutoreleaseValueInst, Unhandled)
24452445
CONSTANT_TRANSLATION(BeginUnpairedAccessInst, Unhandled)
24462446
CONSTANT_TRANSLATION(EndUnpairedAccessInst, Unhandled)
2447-
CONSTANT_TRANSLATION(AssignInst, Unhandled)
2448-
CONSTANT_TRANSLATION(AssignByWrapperInst, Unhandled)
2449-
CONSTANT_TRANSLATION(AssignOrInitInst, Unhandled)
24502447

24512448
//===---
24522449
// Packs
@@ -2493,6 +2490,13 @@ CONSTANT_TRANSLATION(UnownedRetainInst, Asserting)
24932490
CONSTANT_TRANSLATION(AllocPackMetadataInst, Asserting)
24942491
CONSTANT_TRANSLATION(DeallocPackMetadataInst, Asserting)
24952492

2493+
// All of these instructions should be removed by DI which runs before us in the
2494+
// pass pipeline.
2495+
CONSTANT_TRANSLATION(AssignInst, Asserting)
2496+
CONSTANT_TRANSLATION(AssignByWrapperInst, Asserting)
2497+
CONSTANT_TRANSLATION(AssignOrInitInst, Asserting)
2498+
2499+
24962500
#undef CONSTANT_TRANSLATION
24972501

24982502
#ifdef LOOKTHROUGH_IF_NONSENDABLE_RESULT_REQUIRE_OTHERWISE

0 commit comments

Comments
 (0)