Add explicit init from BinaryInteger to CGFloat

stephentyrone · stephentyrone · commit 11246be177a4 · 2020-06-30T11:55:36.000-04:00
The override was previously missing, which meant that we fell back on the generic implementation; we should simply forward this to the NativeType implementation instead.
diff --git a/stdlib/public/Darwin/CoreGraphics/CGFloat.swift.gyb b/stdlib/public/Darwin/CoreGraphics/CGFloat.swift.gyb
@@ -61,9 +61,13 @@ public struct CGFloat {
 }
 
 extension CGFloat : SignedNumeric {
+  @_alwaysEmitIntoClient // availability
+  public init<T: BinaryInteger>(_ source: T) {
+    self.native = NativeType(source)
+  }
 
   @_transparent
-  public init?<T : BinaryInteger>(exactly source: T) {
+  public init?<T: BinaryInteger>(exactly source: T) {
     guard let native = NativeType(exactly: source) else { return nil }
     self.native = native
   }
@@ -72,7 +76,6 @@ extension CGFloat : SignedNumeric {
   public var magnitude: CGFloat {
     return CGFloat(native.magnitude)
   }
-
 }
 
 extension CGFloat : BinaryFloatingPoint {

Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,13 @@ public struct CGFloat {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`extension CGFloat : SignedNumeric {`
	`64`	`+ @_alwaysEmitIntoClient // availability`
	`65`	`+ public init<T: BinaryInteger>(_ source: T) {`
	`66`	`+ self.native = NativeType(source)`
	`67`	`+ }`
`64`	`68`
`65`	`69`	`@_transparent`
`66`		`- public init?<T : BinaryInteger>(exactly source: T) {`
	`70`	`+ public init?<T: BinaryInteger>(exactly source: T) {`
`67`	`71`	`guard let native = NativeType(exactly: source) else { return nil }`
`68`	`72`	`self.native = native`
`69`	`73`	`}`
`@@ -72,7 +76,6 @@ extension CGFloat : SignedNumeric {`
`72`	`76`	`public var magnitude: CGFloat {`
`73`	`77`	`return CGFloat(native.magnitude)`
`74`	`78`	`}`
`75`		`-`
`76`	`79`	`}`
`77`	`80`
`78`	`81`	`extension CGFloat : BinaryFloatingPoint {`