[CS] Update splice logic in simplifyLocator to handle situations where the index expression isn't a tuple or paren expression (swiftlang#32356)

Author: theblixguy

lib/Sema/ConstraintSystem.cpp

@@ -3451,6 +3451,13 @@ void constraints::simplifyLocator(ASTNode &anchor,
       if (auto subscriptExpr = getAsExpr<SubscriptExpr>(anchor)) {
         anchor = subscriptExpr->getIndex();
         path = path.slice(1);
+
+        // TODO: It would be better if the index expression was always wrapped
+        // in a ParenExpr (if there is no label).
+        if (!(isExpr<TupleExpr>(anchor) || isExpr<ParenExpr>(anchor)) &&
+            !path.empty() && path[0].is<LocatorPathElt::ApplyArgToParam>()) {
+          path = path.slice(1);
+        }
         continue;
       }
 

validation-test/compiler_crashers_2_fixed/sr12990.swift

@@ -0,0 +1,11 @@
+// RUN: %target-swift-frontend -typecheck %s -verify
+
+class ContainerTransition {
+  var viewControllers: [Int: String]?
+  func completeTransition() {
+    viewControllers?[Int//.max
+    // expected-error@-1 {{no exact matches in call to subscript}}
+    // expected-note@-2 {{found candidate with type '((Int).Type) -> Dictionary<Int, String>.SubSequence' (aka '(Int.Type) -> Slice<Dictionary<Int, String>>')}}
+    // expected-note@-3 {{to match this opening '['}}
+  } // expected-error {{expected ']' in expression list}}
+}