Skip to content

Commit 15665a1

Browse files
authored
Merge pull request swiftlang#33225 from brentdax/stop-pretending-5.3
[5.3] Stop pretending that macOS 11 is macOS 10.16
2 parents 5d3b598 + 15074dc commit 15665a1

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

lib/Driver/DarwinToolChains.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -619,14 +619,6 @@ toolchains::Darwin::addDeploymentTargetArgs(ArgStringList &Arguments,
619619
micro = firstMacARM64e.getSubminor().getValueOr(0);
620620
}
621621

622-
// Temporary hack: adjust macOS version passed to the linker from
623-
// 11 down to 10.16, but only for x86.
624-
if (triple.isX86() && major == 11) {
625-
major = 10;
626-
minor = 16;
627-
micro = 0;
628-
}
629-
630622
break;
631623
case DarwinPlatformKind::IPhoneOS:
632624
case DarwinPlatformKind::IPhoneOSSimulator:

test/Driver/linker.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,22 +107,22 @@
107107
// RUN: %swiftc_driver -driver-print-jobs -target x86_64-apple-macosx10.9 -sdk %S/Inputs/MacOSX10.15.sdk %s 2>&1 | %FileCheck -check-prefix MACOS_UNVERSIONED %s
108108

109109
// Check arm64 macOS first deployment version adjustment.
110-
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx10.15.1 %s 2>&1 | %FileCheck -check-prefix ARM64E_MACOS_LINKER %s
110+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx10.15.1 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
111111

112-
// Check x86 macOS 11 deployment version adjustment.
113-
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix X86_MACOS11_LINKER %s
114-
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix ARM64E_MACOS_LINKER %s
112+
// Check x86 macOS 11 deployment version adjustment is gone.
113+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx10.16 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
114+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
115+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
115116

116117
// Check arm64 simulators first deployment version adjustment.
117118
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-ios13.0-simulator %s 2>&1 | %FileCheck -check-prefix ARM64_IOS_SIMULATOR_LINKER %s
118119

119120

120121
// MACOS_10_15: -platform_version macos 10.9.0 10.15.0
121122
// MACOS_10_15_4: -platform_version macos 10.9.0 10.15.4
123+
// MACOS_11_0: -platform_version macos 11.0.0
122124
// MACOS_UNVERSIONED: -platform_version macos 10.9.0 0.0.0
123125

124-
// ARM64E_MACOS_LINKER: -platform_version macos 11.0.0
125-
// X86_MACOS11_LINKER: -platform_version macos 10.16.0
126126
// X86_64_WATCHOS_SIM_LINKER: -platform_version watchos-simulator 7.0.0
127127
// ARM64_IOS_SIMULATOR_LINKER: -platform_version ios-simulator 14.0.0
128128

0 commit comments

Comments
 (0)