[constant-folding] Remove unneeded code.

gottesmm · gottesmm · commit 16b1765c9586 · 2019-10-27T22:03:11.000-07:00
recursivelyDeleteTriviallyDeadInstructions will handle this for us when it
deletes the instruction. So in fact, this was actually a use of an invalid
pointer. Good thing we never dereferenced it.
diff --git a/lib/SILOptimizer/Utils/ConstantFolding.cpp b/lib/SILOptimizer/Utils/ConstantFolding.cpp
@@ -1501,7 +1501,6 @@ bool ConstantFolder::constantFoldStringConcatenation(ApplyInst *AI) {
       assert(DeadI);
       recursivelyDeleteTriviallyDeadInstructions(DeadI, /*force*/ true,
                                                  RemoveCallback);
-      WorkList.remove(DeadI);
     }
   }
   // Schedule users of the new instruction for constant folding.

Original file line number	Diff line number	Diff line change
`@@ -1501,7 +1501,6 @@ bool ConstantFolder::constantFoldStringConcatenation(ApplyInst *AI) {`
`1501`	`1501`	`assert(DeadI);`
`1502`	`1502`	`recursivelyDeleteTriviallyDeadInstructions(DeadI, /force/ true,`
`1503`	`1503`	`RemoveCallback);`
`1504`		`- WorkList.remove(DeadI);`
`1505`	`1504`	`}`
`1506`	`1505`	`}`
`1507`	`1506`	`// Schedule users of the new instruction for constant folding.`