[6.1] [AST] Remove assert from ModuleDecl::getFiles

hamishknight · hamishknight · commit 177a564d479e · 2024-11-21T21:36:50.000Z
This can be hit for `IsNonUserModuleRequest`. On
main this is properly fixed by enforcing that a
ModuleDecl's files are immutable after construction.

rdar://137769081
diff --git a/include/swift/AST/Module.h b/include/swift/AST/Module.h
@@ -399,7 +399,6 @@ class ModuleDecl
   void setBypassResilience() { BypassResilience = true; }
 
   ArrayRef<FileUnit *> getFiles() {
-    ASSERT(!Files.empty() || failedToLoad());
     return Files;
   }
   ArrayRef<const FileUnit *> getFiles() const {

Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,6 @@ class ModuleDecl`
`399`	`399`	`void setBypassResilience() { BypassResilience = true; }`
`400`	`400`
`401`	`401`	`ArrayRef<FileUnit *> getFiles() {`
`402`		`- ASSERT(!Files.empty() \|\| failedToLoad());`
`403`	`402`	`return Files;`
`404`	`403`	`}`
`405`	`404`	`ArrayRef<const FileUnit *> getFiles() const {`