[move-only] Change "move only field consumed here" msg -> "consuming use"

In a subsequent commit, I am going to change all of the "consuming use"/"non
consuming use" to "consuming use here" and "non consuming use here". But for
now, lets standardize.

Author: gottesmm

test/SILOptimizer/moveonly_objectchecker_diagnostics.swift

@@ -953,23 +953,23 @@ public func aggStructConsumeField(_ x: AggStruct) { // expected-error {{'x' has
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggStructConsumeFieldArg(_ x2: AggStruct) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggStructConsumeFieldOwnedArg(_ x2: __owned AggStruct) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
@@ -1000,23 +1000,23 @@ public func aggStructConsumeGrandField(_ x: AggStruct) { // expected-error {{'x'
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggStructConsumeGrandFieldArg(_ x2: AggStruct) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggStructConsumeGrandFieldOwnedArg(_ x2: __owned AggStruct) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}    
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
@@ -1228,23 +1228,23 @@ public func aggGenericStructConsumeField(_ x: AggGenericStruct<Klass>) { // expe
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeFieldArg(_ x2: AggGenericStruct<Klass>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeFieldOwnedArg(_ x2: __owned AggGenericStruct<Klass>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
@@ -1275,23 +1275,23 @@ public func aggGenericStructConsumeGrandField(_ x: AggGenericStruct<Klass>) { //
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeGrandFieldArg(_ x2: AggGenericStruct<Klass>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeGrandFieldOwnedArg(_ x2: __owned AggGenericStruct<Klass>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
@@ -1496,23 +1496,23 @@ public func aggGenericStructConsumeField<T>(_ x: AggGenericStruct<T>) { // expec
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeFieldArg<T>(_ x2: AggGenericStruct<T>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeFieldOwnedArg<T>(_ x2: __owned AggGenericStruct<T>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.lhs) // expected-note {{consuming use}}
     }
 }
 
@@ -1543,23 +1543,23 @@ public func aggGenericStructConsumeGrandField<T>(_ x: AggGenericStruct<T>) { //
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeGrandFieldArg<T>(_ x2: AggGenericStruct<T>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }
 
 public func aggGenericStructConsumeGrandFieldOwnedArg<T>(_ x2: __owned AggGenericStruct<T>) {
     // expected-error @-1 {{'x2' has a move only field that was consumed before later uses}}
     classConsume(x2.pair.lhs)
     for _ in 0..<1024 {
-        classConsume(x2.pair.lhs) // expected-note {{move only field consumed here}}
+        classConsume(x2.pair.lhs) // expected-note {{consuming use}}
     }
 }