Skip to content

Commit 1f0fcb8

Browse files
authored
Merge pull request swiftlang#12555 from slavapestov/fix-a-warning
SIL: Fix a warning and add a FIXME
2 parents abb6156 + cc5264c commit 1f0fcb8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/SIL/SILWitnessTable.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,10 @@ bool SILWitnessTable::conformanceIsSerialized(ProtocolConformance *conformance,
166166
return true;
167167

168168
auto *nominal = conformance->getType()->getAnyNominal();
169-
// Only serialize if the witness table is sufficiently static, and resilience
170-
// is explicitly enabled for this compilation or if we serialize all eligible
171-
// witness tables.
172-
auto moduleIsResilient = strategy == ResilienceStrategy::Resilient;
169+
// Only serialize witness tables for fixed layout types.
170+
//
171+
// FIXME: This is not the right long term solution. We need an explicit
172+
// mechanism for declaring conformances as 'fragile'.
173173
auto protocolIsPublic =
174174
conformance->getProtocol()->getEffectiveAccess() >= AccessLevel::Public;
175175
auto typeIsPublic = nominal->getEffectiveAccess() >= AccessLevel::Public;

0 commit comments

Comments
 (0)