[ownership] When looking at an interior pointer's uses, look through store_borrow.

The store_borrow's result is a sub-interior pointer that ensures that any uses
of the interior pointer are within the lifetime of the borrowed value that is
being stored. But fundamentally this is just embedding lifetime ownership on
def-use edges and once ossa is lowered the result is just the destination
address. So it makes sense to include the uses of the result of the store_borrow
as the dest's uses.

Author: gottesmm

lib/SIL/Utils/OwnershipUtils.cpp

@@ -707,13 +707,12 @@ bool InteriorPointerOperand::findTransitiveUsesForAddress(
     // and do not need to check transitive uses of.
     if (isa<LoadInst>(user) || isa<CopyAddrInst>(user) ||
         isIncidentalUse(user) || isa<StoreInst>(user) ||
-        isa<StoreBorrowInst>(user) || isa<PartialApplyInst>(user) ||
-        isa<DestroyAddrInst>(user) || isa<AssignInst>(user) ||
-        isa<AddressToPointerInst>(user) || isa<YieldInst>(user) ||
-        isa<LoadUnownedInst>(user) || isa<StoreUnownedInst>(user) ||
-        isa<EndApplyInst>(user) || isa<LoadWeakInst>(user) ||
-        isa<StoreWeakInst>(user) || isa<AssignByWrapperInst>(user) ||
-        isa<BeginUnpairedAccessInst>(user) ||
+        isa<PartialApplyInst>(user) || isa<DestroyAddrInst>(user) ||
+        isa<AssignInst>(user) || isa<AddressToPointerInst>(user) ||
+        isa<YieldInst>(user) || isa<LoadUnownedInst>(user) ||
+        isa<StoreUnownedInst>(user) || isa<EndApplyInst>(user) ||
+        isa<LoadWeakInst>(user) || isa<StoreWeakInst>(user) ||
+        isa<AssignByWrapperInst>(user) || isa<BeginUnpairedAccessInst>(user) ||
         isa<EndUnpairedAccessInst>(user) || isa<WitnessMethodInst>(user) ||
         isa<SwitchEnumAddrInst>(user) || isa<CheckedCastAddrBranchInst>(user) ||
         isa<SelectEnumAddrInst>(user) || isa<InjectEnumAddrInst>(user)) {
@@ -726,7 +725,7 @@ bool InteriorPointerOperand::findTransitiveUsesForAddress(
         isa<OpenExistentialAddrInst>(user) ||
         isa<InitExistentialAddrInst>(user) || isa<InitEnumDataAddrInst>(user) ||
         isa<BeginAccessInst>(user) || isa<TailAddrInst>(user) ||
-        isa<IndexAddrInst>(user) ||
+        isa<IndexAddrInst>(user) || isa<StoreBorrowInst>(user) ||
         isa<UnconditionalCheckedCastAddrInst>(user) ||
         isa<UncheckedAddrCastInst>(user)) {
       for (SILValue r : user->getResults()) {

test/SIL/ownership-verifier/interior_pointer.sil

@@ -118,3 +118,21 @@ bb0(%0 : @owned $Builtin.NativeObject):
   %9999 = tuple()
   return %9999 : $()
 }
+
+// CHECK-LABEL: Error#: 0. Begin Error in Function: 'recursive_interior_pointer_error'
+// CHECK-NEXT: Found outside of lifetime use?!
+// CHECK-NEXT: Value:   %2 = begin_borrow %0 : $KlassUser               // users: %5, %3
+// CHECK-NEXT: Consuming User:   end_borrow %2 : $KlassUser                      // id: %5
+// CHECK-NEXT: Non Consuming User:   %7 = load [copy] %4 : $*Klass                   // user: %8
+// CHECK-NEXT: Block: bb0
+// CHECK: Error#: 0. End Error in Function: 'recursive_interior_pointer_error'
+sil [ossa] @recursive_interior_pointer_error : $@convention(thin) (@owned KlassUser, @guaranteed Klass) -> @owned Klass {
+bb0(%0 : @owned $KlassUser, %0a : @guaranteed $Klass):
+  %1 = begin_borrow %0 : $KlassUser
+  %2 = ref_tail_addr %1 : $KlassUser, $Klass
+  %result = store_borrow %0a to %2 : $*Klass
+  end_borrow %1 : $KlassUser
+  destroy_value %0 : $KlassUser
+  %3 = load [copy] %result : $*Klass
+  return %3 : $Klass
+}