Remove an unnecessary call to createTypeChecker

hamishknight · hamishknight · commit 27e3d9f6a78b · 2019-11-07T12:41:37.000-08:00
We appear to always have a TypeChecker registered
at this point.
diff --git a/lib/Sema/TypeChecker.cpp b/lib/Sema/TypeChecker.cpp
@@ -599,7 +599,8 @@ bool swift::performTypeLocChecking(ASTContext &Ctx, TypeLoc &T,
   Optional<DiagnosticSuppression> suppression;
   if (!ProduceDiagnostics)
     suppression.emplace(Ctx.Diags);
-  TypeChecker &TC = createTypeChecker(Ctx);
+  assert(Ctx.getLegacyGlobalTypeChecker() &&
+         "Should have a TypeChecker registered");
   return TypeChecker::validateType(Ctx, T, resolution, options);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -599,7 +599,8 @@ bool swift::performTypeLocChecking(ASTContext &Ctx, TypeLoc &T,`
`599`	`599`	`Optional<DiagnosticSuppression> suppression;`
`600`	`600`	`if (!ProduceDiagnostics)`
`601`	`601`	`suppression.emplace(Ctx.Diags);`
`602`		`- TypeChecker &TC = createTypeChecker(Ctx);`
	`602`	`+ assert(Ctx.getLegacyGlobalTypeChecker() &&`
	`603`	`+ "Should have a TypeChecker registered");`
`603`	`604`	`return TypeChecker::validateType(Ctx, T, resolution, options);`
`604`	`605`	`}`
`605`	`606`