[Sema] Remove invalid @_spi attributes

xymus · xymus · commit 2bbebcb18022 · 2020-03-04T16:43:05.000-08:00
diff --git a/lib/Sema/TypeCheckAttr.cpp b/lib/Sema/TypeCheckAttr.cpp
@@ -867,11 +867,10 @@ void AttributeChecker::visitSPIAccessControlAttr(SPIAccessControlAttr *attr) {
   if (auto VD = dyn_cast<ValueDecl>(D)) {
     auto declAccess = VD->getFormalAccess();
     if (declAccess < AccessLevel::Public) {
-      diagnose(attr->getLocation(),
-               diag::spi_attribute_on_non_public,
-               declAccess,
-               D->getDescriptiveKind())
-        .fixItRemove(attr->getRange());
+      diagnoseAndRemoveAttr(attr,
+                            diag::spi_attribute_on_non_public,
+                            declAccess,
+                            D->getDescriptiveKind());
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -867,11 +867,10 @@ void AttributeChecker::visitSPIAccessControlAttr(SPIAccessControlAttr *attr) {`
`867`	`867`	`if (auto VD = dyn_cast<ValueDecl>(D)) {`
`868`	`868`	`auto declAccess = VD->getFormalAccess();`
`869`	`869`	`if (declAccess < AccessLevel::Public) {`
`870`		`- diagnose(attr->getLocation(),`
`871`		`- diag::spi_attribute_on_non_public,`
`872`		`- declAccess,`
`873`		`- D->getDescriptiveKind())`
`874`		`- .fixItRemove(attr->getRange());`
	`870`	`+ diagnoseAndRemoveAttr(attr,`
	`871`	`+ diag::spi_attribute_on_non_public,`
	`872`	`+ declAccess,`
	`873`	`+ D->getDescriptiveKind());`
`875`	`874`	`}`
`876`	`875`	`}`
`877`	`876`	`}`