Merge pull request swiftlang#35909 from slavapestov/existential-type-unsupported-trigger

Sema: Don't need to explicitly calculate existentialTypeSupported()

Author: slavapestov

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -2359,9 +2359,6 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
       llvm::errs() << "\n";
     }
 
-    // Explicitly calculate this bit.
-    (void) PD->existentialTypeSupported();
-
     // Explicity compute the requirement signature to detect errors.
     (void) PD->getRequirementSignature();
 

test/decl/protocol/conforms/circular_validation.swift

@@ -13,6 +13,6 @@ struct S : P { // expected-error {{type 'S' does not conform to protocol 'P'}}
 }
 
 // FIXME: Lousy diagnostics on this case.
-protocol SR9224_Foo: SR9224_Foobar {} // expected-error 2 {{protocol 'SR9224_Foo' refines itself}}
-protocol SR9224_Bar: SR9224_Foobar {} // expected-note {{protocol 'SR9224_Bar' declared here}}
+protocol SR9224_Foo: SR9224_Foobar {} // expected-error {{protocol 'SR9224_Foo' refines itself}}
+protocol SR9224_Bar: SR9224_Foobar {}
 typealias SR9224_Foobar = SR9224_Foo & SR9224_Bar

test/decl/protocol/protocols.swift

@@ -101,10 +101,10 @@ struct DoesNotConform : Up {
 
 // Circular protocols
 
-protocol CircleMiddle : CircleStart { func circle_middle() } // expected-error 2 {{protocol 'CircleMiddle' refines itself}}
-// expected-note@-1 {{protocol 'CircleMiddle' declared here}}
-protocol CircleStart : CircleEnd { func circle_start() } // expected-error {{protocol 'CircleStart' refines itself}}
-// expected-note@-1 2 {{protocol 'CircleStart' declared here}}
+protocol CircleMiddle : CircleStart { func circle_middle() } // expected-error {{protocol 'CircleMiddle' refines itself}}
+// expected-note@-1 2 {{protocol 'CircleMiddle' declared here}}
+protocol CircleStart : CircleEnd { func circle_start() } // expected-error 2 {{protocol 'CircleStart' refines itself}}
+// expected-note@-1 {{protocol 'CircleStart' declared here}}
 protocol CircleEnd : CircleMiddle { func circle_end()} // expected-note 3 {{protocol 'CircleEnd' declared here}}
 
 protocol CircleEntry : CircleTrivial { }

test/type/protocol_types.swift

@@ -138,3 +138,8 @@ struct BadSubscript {
     set {}
   }
 }
+
+struct OuterGeneric<T> {
+  func contextuallyGenericMethod() where T == HasAssoc {}
+  // expected-error@-1 {{protocol 'HasAssoc' can only be used as a generic constraint because it has Self or associated type requirements}}
+}