Remove the list of synthesized decls"

This used to be a lot more relevant a long time ago when typeCheckFunctionsAndExternalDecls actually did type check external functions defined in C.  Now, it serves no purpose.

The validation order change from just type checking these things eagerly doesn't seem to affect anything.

Author: CodaFi

include/swift/AST/ASTContext.h

@@ -553,10 +553,6 @@ class ASTContext final {
                                ForeignLanguage language,
                                const DeclContext *dc);
 
-  /// Add a declaration that was synthesized to a per-source file list if
-  /// if is part of a source file.
-  void addSynthesizedDecl(Decl *decl);
-
   /// Add a cleanup function to be called when the ASTContext is deallocated.
   void addCleanup(std::function<void(void)> cleanup);
 

lib/AST/ASTContext.cpp

@@ -1366,12 +1366,6 @@ bool ASTContext::hasArrayLiteralIntrinsics() const {
     && getDeallocateUninitializedArray();
 }
 
-void ASTContext::addSynthesizedDecl(Decl *decl) {
-  auto *fileUnit = decl->getDeclContext()->getModuleScopeContext();
-  if (auto *sf = dyn_cast<SourceFile>(fileUnit))
-    sf->SynthesizedDecls.push_back(decl);
-}
-
 void ASTContext::addCleanup(std::function<void(void)> cleanup) {
   getImpl().Cleanups.push_back(std::move(cleanup));
 }

lib/Sema/DerivedConformanceCodable.cpp

@@ -741,9 +741,8 @@ static FuncDecl *deriveEncodable_encode(DerivedConformance &derived) {
   encodeDecl->copyFormalAccessFrom(derived.Nominal,
                                    /*sourceIsParentContext*/ true);
 
-  C.addSynthesizedDecl(encodeDecl);
-
   derived.addMembersToConformanceContext({encodeDecl});
+
   return encodeDecl;
 }
 
@@ -1019,9 +1018,8 @@ static ValueDecl *deriveDecodable_init(DerivedConformance &derived) {
   initDecl->copyFormalAccessFrom(derived.Nominal,
                                  /*sourceIsParentContext*/ true);
 
-  C.addSynthesizedDecl(initDecl);
-
   derived.addMembersToConformanceContext({initDecl});
+
   return initDecl;
 }
 

lib/Sema/DerivedConformanceCodingKey.cpp

@@ -145,9 +145,8 @@ static ValueDecl *deriveInitDecl(DerivedConformance &derived, Type paramType,
 
   initDecl->setAccess(derived.Nominal->getFormalAccess());
 
-  C.addSynthesizedDecl(initDecl);
-
   derived.addMembersToConformanceContext({initDecl});
+
   return initDecl;
 }
 
@@ -176,9 +175,7 @@ static ValueDecl *deriveProperty(DerivedConformance &derived, Type type,
   // Synthesize the body.
   synthesizer(getterDecl);
 
-  auto *dc = cast<IterableDeclContext>(derived.ConformanceDecl);
-  dc->addMember(propDecl);
-  dc->addMember(pbDecl);
+  derived.addMembersToConformanceContext({propDecl, pbDecl});
   return propDecl;
 }
 

lib/Sema/DerivedConformanceEquatableHashable.cpp

@@ -769,8 +769,6 @@ deriveEquatable_eq(
 
   eqDecl->copyFormalAccessFrom(derived.Nominal, /*sourceIsParentContext*/ true);
 
-  C.addSynthesizedDecl(eqDecl);
-
   // Add the operator to the parent scope.
   derived.addMembersToConformanceContext({eqDecl});
 
@@ -890,9 +888,8 @@ deriveHashable_hashInto(
 
   hashDecl->copyFormalAccessFrom(derived.Nominal);
 
-  C.addSynthesizedDecl(hashDecl);
-
   derived.addMembersToConformanceContext({hashDecl});
+
   return hashDecl;
 }
 
@@ -1253,8 +1250,6 @@ static ValueDecl *deriveHashable_hashValue(DerivedConformance &derived) {
   auto *patDecl = PatternBindingDecl::createImplicit(
       C, StaticSpellingKind::None, hashValuePat, /*InitExpr*/ nullptr,
       parentDC);
-  C.addSynthesizedDecl(hashValueDecl);
-  C.addSynthesizedDecl(getterDecl);
 
   derived.addMembersToConformanceContext({hashValueDecl, patDecl});
   return hashValueDecl;

lib/Sema/DerivedConformanceRawRepresentable.cpp

@@ -434,8 +434,6 @@ deriveRawRepresentable_init(DerivedConformance &derived) {
   // an instance without function call overhead.
   maybeMarkAsInlinable(derived, initDecl);
 
-  C.addSynthesizedDecl(initDecl);
-
   derived.addMembersToConformanceContext({initDecl});
   return initDecl;
 }

lib/Sema/DerivedConformances.cpp

@@ -311,7 +311,6 @@ DerivedConformance::declareDerivedPropertyGetter(VarDecl *property,
 
   getterDecl->copyFormalAccessFrom(property);
 
-  C.addSynthesizedDecl(getterDecl);
 
   return getterDecl;
 }

lib/Sema/TypeChecker.cpp

@@ -318,8 +318,6 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)
   } while (currentFunctionIdx < TC.definedFunctions.size() ||
            currentSynthesizedDecl < SF.SynthesizedDecls.size());
 
-  // FIXME: Horrible hack. Store this somewhere more appropriate.
-  SF.LastCheckedSynthesizedDecl = currentSynthesizedDecl;
 
   // Compute captures for functions and closures we visited.
   for (auto *closure : TC.ClosuresWithUncomputedCaptures) {