explicitly declare virtual destructors

ktoso · ktoso · commit 2f7a1b4c34a4 · 2023-01-25T11:48:12.000+09:00
diff --git a/stdlib/public/Concurrency/TaskGroup.cpp b/stdlib/public/Concurrency/TaskGroup.cpp
@@ -666,6 +666,8 @@ class AccumulatingTaskGroup: public TaskGroupBase {
 
   virtual void destroy() override;
 
+  virtual ~AccumulatingTaskGroup() {}
+
   virtual bool isDiscardingResults() const override {
     return false;
   }
@@ -714,6 +716,8 @@ class DiscardingTaskGroup: public TaskGroupBase {
 
   virtual void destroy() override;
 
+  virtual ~DiscardingTaskGroup() {}
+
   virtual bool isDiscardingResults() const override {
     return true;
   }

Original file line number	Diff line number	Diff line change
`@@ -666,6 +666,8 @@ class AccumulatingTaskGroup: public TaskGroupBase {`
`666`	`666`
`667`	`667`	`virtual void destroy() override;`
`668`	`668`
	`669`	`+ virtual ~AccumulatingTaskGroup() {}`
	`670`	`+`
`669`	`671`	`virtual bool isDiscardingResults() const override {`
`670`	`672`	`return false;`
`671`	`673`	`}`
`@@ -714,6 +716,8 @@ class DiscardingTaskGroup: public TaskGroupBase {`
`714`	`716`
`715`	`717`	`virtual void destroy() override;`
`716`	`718`
	`719`	`+ virtual ~DiscardingTaskGroup() {}`
	`720`	`+`
`717`	`721`	`virtual bool isDiscardingResults() const override {`
`718`	`722`	`return true;`
`719`	`723`	`}`