Merge pull request swiftlang#79557 from tshortli/warnings

Gardening: Fix various warnings

Author: tshortli

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -1364,7 +1364,6 @@ Type DefaultArgumentTypeRequest::evaluate(Evaluator &evaluator,
 DefaultArgumentInitializer *
 DefaultArgumentInitContextRequest::evaluate(Evaluator &eval,
                                             ParamDecl *param) const {
-  auto &ctx = param->getASTContext();
   auto *parentDC = param->getDeclContext();
   auto *paramList = getParameterList(cast<ValueDecl>(parentDC->getAsDecl()));
 

stdlib/public/Concurrency/Task.swift

@@ -766,7 +766,7 @@ extension Task where Failure == Never {
 
     var task: Builtin.NativeObject?
     #if $BuiltinCreateAsyncTaskName
-    if var name {
+    if let name {
       task =
         name.utf8CString.withUnsafeBufferPointer { nameBytes in
           Builtin.createTask(
@@ -935,27 +935,27 @@ self._task = task
 
   var task: Builtin.NativeObject?
   #if $BuiltinCreateAsyncTaskName
-if var name {
-  task =
-    name.utf8CString.withUnsafeBufferPointer { nameBytes in
-      Builtin.createTask(
-        flags: flags,
-        initialSerialExecutor: builtinSerialExecutor,
-        taskName: nameBytes.baseAddress!._rawValue,
-        operation: operation).0
-    }
-}
+  if let name {
+    task =
+      name.utf8CString.withUnsafeBufferPointer { nameBytes in
+        Builtin.createTask(
+          flags: flags,
+          initialSerialExecutor: builtinSerialExecutor,
+          taskName: nameBytes.baseAddress!._rawValue,
+          operation: operation).0
+      }
+  }
   #endif
-if task == nil {
-  // either no task name was set, or names are unsupported
-  task = Builtin.createTask(
-  flags: flags,
-  initialSerialExecutor: builtinSerialExecutor,
-  operation: operation).0
-}
+  if task == nil {
+    // either no task name was set, or names are unsupported
+    task = Builtin.createTask(
+      flags: flags,
+      initialSerialExecutor: builtinSerialExecutor,
+      operation: operation).0
+  }
 
-self._task = task!
-}
+  self._task = task!
+  }
   #endif
 }
 
@@ -1076,7 +1076,7 @@ extension Task where Failure == Never {
 
     var task: Builtin.NativeObject?
     #if $BuiltinCreateAsyncTaskName
-    if var name {
+    if let name {
       task =
         name.utf8CString.withUnsafeBufferPointer { nameBytes in
           Builtin.createTask(
@@ -1218,7 +1218,7 @@ extension Task where Failure == Error {
 
     var task: Builtin.NativeObject?
     #if $BuiltinCreateAsyncTaskName
-    if var name {
+    if let name {
       task =
         name.utf8CString.withUnsafeBufferPointer { nameBytes in
           Builtin.createTask(

stdlib/public/Concurrency/TaskGroup+addTask.swift.gyb

@@ -243,7 +243,7 @@ extension ${TYPE} {
     % # we definitely have the prior ones, as we always keep adding parameters.
     % if HAS_TASK_NAME:
     #if $BuiltinCreateAsyncTaskName
-    if var name {
+    if let name {
       task =
         name.utf8CString.withUnsafeBufferPointer { nameBytes in
           ${TASK_CREATE_FN}(

stdlib/public/libexec/swift-backtrace/main.swift

@@ -551,7 +551,7 @@ Generate a backtrace for the parent process.
           // If the output path is a directory, generate a filename
           let name = target!.name
           let pid = target!.pid
-          var now = timespec()
+          var now = timespec(tv_sec: 0, tv_nsec: 0)
 
           if clock_gettime(CLOCK_REALTIME, &now) != 0 {
             now.tv_sec = time(nil)