Merge pull request swiftlang#63391 from apple/QuietMisdreavus/factory-init-sgf

don't print the "not inherited" mark in SGF declarations

Author: QuietMisdreavus

include/swift/AST/PrintOptions.h

@@ -318,6 +318,9 @@ struct PrintOptions {
   /// Suppress emitting @available(*, noasync)
   bool SuppressNoAsyncAvailabilityAttr = false;
 
+  /// Whether to print the \c{/*not inherited*/} comment on factory initializers.
+  bool PrintFactoryInitializerComment = true;
+
   /// How to print opaque return types.
   enum class OpaqueReturnTypePrintingMode {
     /// 'some P1 & P2'.

lib/AST/ASTPrinter.cpp

@@ -4373,7 +4373,9 @@ void PrintAST::visitConstructorDecl(ConstructorDecl *decl) {
              "unexpected convenience initializer");
     }
   } else if (decl->getInitKind() == CtorInitializerKind::Factory) {
-    Printer << "/*not inherited*/ ";
+    if (Options.PrintFactoryInitializerComment) {
+      Printer << "/*not inherited*/ ";
+    }
   }
 
   printContextIfNeeded(decl);

lib/SymbolGraphGen/SymbolGraph.cpp

@@ -67,6 +67,7 @@ PrintOptions SymbolGraph::getDeclarationFragmentsPrintOptions() const {
   Opts.PrintGenericRequirements = true;
   Opts.PrintInherited = false;
   Opts.ExplodeEnumCaseDecls = true;
+  Opts.PrintFactoryInitializerComment = false;
 
   Opts.ExclusiveAttrList.clear();
 

test/SymbolGraph/ClangImporter/FactoryInit.swift

@@ -0,0 +1,8 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-symbolgraph-extract -sdk %clang-importer-sdk -module-name FactoryInit -F %S/Inputs/FactoryInit -output-dir %t -pretty-print -v
+
+// REQUIRES: objc_interop
+
+// RUN: %FileCheck %s --input-file %t/FactoryInit.symbols.json
+
+// CHECK-NOT: not inherited

test/SymbolGraph/ClangImporter/Inputs/FactoryInit/FactoryInit.framework/FactoryInit

@@ -0,0 +1,8 @@
+@import Foundation;
+
+__attribute__((swift_name("SomeClass")))
+@interface IAMSomeClass : NSObject
+@end
+
+__attribute__((swift_name("SomeClass.init(value:)")))
+IAMSomeClass * _Nonnull MakeIAMSomeClass(double x);

test/SymbolGraph/ClangImporter/Inputs/FactoryInit/FactoryInit.framework/Headers/FactoryInit.h

@@ -0,0 +1,4 @@
+framework module FactoryInit {
+  header "FactoryInit.h"
+  export *
+}