Uniformly iterate over the pattern binding entry indices

Clarify a bunch of C-style for loops and remove a ton of references to getPatternList().

Author: CodaFi

include/swift/AST/Decl.h

@@ -2212,7 +2212,7 @@ class PatternBindingDecl final : public Decl,
   /// Determines whether this binding either has an initializer expression, or is
   /// default initialized, without performing any type checking on it.
   bool isDefaultInitializable() const {
-    for (unsigned i = 0, e = getNumPatternEntries(); i < e; ++i)
+    for (unsigned i : range(getNumPatternEntries()))
       if (!isDefaultInitializable(i))
         return false;
 

lib/AST/ASTDumper.cpp

@@ -895,7 +895,7 @@ namespace {
     void visitPatternBindingDecl(PatternBindingDecl *PBD) {
       printCommon(PBD, "pattern_binding_decl");
 
-      for (auto idx : indices(PBD->getPatternList())) {
+      for (auto idx : range(PBD->getNumPatternEntries())) {
         OS << '\n';
         printRec(PBD->getPattern(idx));
         if (PBD->getOriginalInit(idx)) {

lib/AST/ASTMangler.cpp

@@ -1606,7 +1606,7 @@ namespace {
 /// least one name, which is probably a reasonable assumption but may
 /// not be adequately enforced.
 static Optional<VarDecl*> findFirstVariable(PatternBindingDecl *binding) {
-  for (auto idx : indices(binding->getPatternList())) {
+  for (auto idx : range(binding->getNumPatternEntries())) {
     auto var = FindFirstVariable().visit(binding->getPattern(idx));
     if (var) return var;
   }

lib/AST/ASTPrinter.cpp

@@ -1665,7 +1665,7 @@ bool ShouldPrintChecker::shouldPrint(const Decl *D,
   // attributes can only be retrieved from the inside VarDecls.
   if (auto *PD = dyn_cast<PatternBindingDecl>(D)) {
     auto ShouldPrint = false;
-    for (auto idx : indices(PD->getPatternList())) {
+    for (auto idx : range(PD->getNumPatternEntries())) {
       ShouldPrint |= shouldPrint(PD->getPattern(idx), Options);
       if (ShouldPrint)
         return true;
@@ -2162,7 +2162,7 @@ void PrintAST::visitPatternBindingDecl(PatternBindingDecl *decl) {
   // variables are immutable, and if so, we print as 'let'.  This allows us to
   // handle the 'let x = 4' case properly at least.
   const VarDecl *anyVar = nullptr;
-  for (auto idx : indices(decl->getPatternList())) {
+  for (auto idx : range(decl->getNumPatternEntries())) {
     decl->getPattern(idx)->forEachVariable([&](VarDecl *V) {
       anyVar = V;
     });
@@ -2190,7 +2190,7 @@ void PrintAST::visitPatternBindingDecl(PatternBindingDecl *decl) {
   }
 
   bool isFirst = true;
-  for (auto idx : indices(decl->getPatternList())) {
+  for (auto idx : range(decl->getNumPatternEntries())) {
     auto *pattern = decl->getPattern(idx);
     if (!shouldPrintPattern(pattern))
       continue;

lib/AST/ASTScopeCreation.cpp

@@ -920,7 +920,7 @@ class NodeAdder
         isInTypeDecl ? DeclVisibilityKind::MemberOfCurrentNominal
                      : DeclVisibilityKind::LocalVariable;
     auto *insertionPoint = parentScope;
-    for (auto i : indices(patternBinding->getPatternList())) {
+    for (auto i : range(patternBinding->getNumPatternEntries())) {
       // TODO: Won't need to do so much work to avoid creating one without
       // a SourceRange once parser is fixed to not create two
       // PatternBindingDecls with same locaiton and getSourceRangeOfThisASTNode
@@ -2054,7 +2054,7 @@ class LocalizableDeclContextCollector : public ASTWalker {
   }
 
   void recordInitializers(PatternBindingDecl *pbd) {
-    for (auto idx : indices(pbd->getPatternList()))
+    for (auto idx : range(pbd->getNumPatternEntries()))
       record(pbd->getInitContext(idx));
   }
 

lib/AST/ASTVerifier.cpp

@@ -2357,7 +2357,7 @@ class Verifier : public ASTWalker {
 
     void verifyChecked(PatternBindingDecl *binding) {
       // Look at all of the VarDecls being bound.
-      for (auto idx : indices(binding->getPatternList()))
+      for (auto idx : range(binding->getNumPatternEntries()))
         if (auto *P = binding->getPattern(idx))
           P->forEachVariable([&](VarDecl *VD) {
             // ParamDecls never get PBD's.

lib/AST/ASTWalker.cpp

@@ -171,7 +171,7 @@ class Traversal : public ASTVisitor<Traversal, Expr*, Stmt*,
         singleVar->getOriginalWrappedProperty() != nullptr;
     }
 
-    for (auto idx : indices(PBD->getPatternList())) {
+    for (auto idx : range(PBD->getNumPatternEntries())) {
       if (Pattern *Pat = doIt(PBD->getPattern(idx)))
         PBD->setPattern(idx, Pat, PBD->getInitContext(idx));
       else

lib/AST/Decl.cpp

@@ -459,7 +459,7 @@ SourceRange Decl::getSourceRangeIncludingAttrs() const {
 
   // Attributes on PatternBindingDecls are attached to VarDecls in AST.
   if (auto *PBD = dyn_cast<PatternBindingDecl>(this)) {
-    for (auto i : indices(PBD->getPatternList()))
+    for (auto i : range(PBD->getNumPatternEntries()))
       PBD->getPattern(i)->forEachVariable([&](VarDecl *VD) {
         for (auto Attr : VD->getAttrs())
           if (Attr->getRange().isValid())

lib/IDE/ExprContextAnalysis.cpp

@@ -686,7 +686,7 @@ class ExprContextAnalyzer {
     switch (D->getKind()) {
     case DeclKind::PatternBinding: {
       auto PBD = cast<PatternBindingDecl>(D);
-      for (unsigned I = 0; I < PBD->getNumPatternEntries(); ++I) {
+      for (unsigned I : range(PBD->getNumPatternEntries())) {
         if (auto Init = PBD->getInit(I)) {
           if (containsTarget(Init)) {
             if (PBD->getPattern(I)->hasType()) {

lib/SILGen/SILGen.cpp

@@ -930,7 +930,7 @@ static bool requiresIVarInitialization(SILGenModule &SGM, ClassDecl *cd) {
     auto pbd = dyn_cast<PatternBindingDecl>(member);
     if (!pbd) continue;
 
-    for (auto i : indices(pbd->getPatternList()))
+    for (auto i : range(pbd->getNumPatternEntries()))
       if (pbd->getExecutableInit(i))
         return true;
   }
@@ -1304,7 +1304,7 @@ void SILGenModule::emitObjCDestructorThunk(DestructorDecl *destructor) {
 
 void SILGenModule::visitPatternBindingDecl(PatternBindingDecl *pd) {
   assert(!TopLevelSGF && "script mode PBDs should be in TopLevelCodeDecls");
-  for (unsigned i = 0, e = pd->getNumPatternEntries(); i != e; ++i)
+  for (auto i : range(pd->getNumPatternEntries()))
     if (pd->getExecutableInit(i))
       emitGlobalInitialization(pd, i);
 }