Merge pull request swiftlang#36539 from aschwaighofer/fix_constant_debug_info_async

IRGen: Fix debug_value emission for constants in async functions

Author: aschwaighofer

lib/IRGen/IRGenSIL.cpp

@@ -928,7 +928,7 @@ class IRGenSILFunction :
     // Mark variables in async functions that don't generate a shadow copy for
     // lifetime extension, so they get spilled into the async context.
     if (!IGM.IRGen.Opts.shouldOptimize() && CurSILFn->isAsync())
-      if (isa<llvm::AllocaInst>(Storage) || isa<llvm::Constant>(Storage)) {
+      if (isa<llvm::AllocaInst>(Storage)) {
         if (emitLifetimeExtendingUse(Storage))
           if (ValueVariables.insert(Storage).second)
             ValueDomPoints.push_back({Storage, getActiveDominancePoint()});
@@ -4718,8 +4718,8 @@ void IRGenSILFunction::visitDebugValueInst(DebugValueInst *i) {
     return;
 
   IndirectionKind Indirection = DirectValue;
-  if (CurSILFn->isAsync() &&
-      !i->getDebugScope()->InlinedCallSite) {
+  if (CurSILFn->isAsync() && !i->getDebugScope()->InlinedCallSite &&
+      (Copy.empty() || !isa<llvm::Constant>(Copy[0]))) {
     Indirection = CoroDirectValue;
   }
 

test/DebugInfo/async-local-var.swift

@@ -12,6 +12,7 @@ func getString() async -> String {
 func wait() async throws {}
 
 public func makeDinner() async throws -> String {
+  let local_constant = 5
   let local = await getString()
   try await wait()
 // CHECK-LABEL: define {{.*}} void @"$s1a10makeDinnerSSyYKFTQ0_"