Skip to content

Commit 42e0d33

Browse files
committed
[windows][msvc2017] Avoid initializer list constructor ambiguity.
MSVC2017 seems to not fallback to the correct overloaded constructor when an initializer list constructor seems to be used, but only fails because the conversion rules. Using parenthesis instead of braces seems to indicate MSVC2017 the right constructor to use, and should work in the rest of the compilers as well. Seems that MSVC2019 is more resilient to this ambiguity. Introduced in swiftlang#34808 and started failing https://ci-external.swift.org/job/oss-swift-windows-x86_64/5953/
1 parent 84360d9 commit 42e0d33

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/swift/Basic/Fingerprint.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ class Fingerprint final {
124124
///
125125
/// Very well, LLVM. A default value you shall have.
126126
friend class llvm::yaml::IO;
127-
Fingerprint() : Core{DIGEST_LENGTH, '0'} {}
127+
Fingerprint() : Core(DIGEST_LENGTH, '0') {}
128128
};
129129

130130
void simple_display(llvm::raw_ostream &out, const Fingerprint &fp);

0 commit comments

Comments
 (0)