Skip to content

Commit 467e6a1

Browse files
Merge pull request swiftlang#75350 from cachemeifyoucan/eng/PR-131940130-swift-6
[6.0][CrossImport][PrefixMap] Make sure overlay file is remapped if used
2 parents 3f16623 + 6d877dd commit 467e6a1

File tree

2 files changed

+27
-5
lines changed

2 files changed

+27
-5
lines changed

lib/DependencyScan/ModuleDependencyScanner.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -950,7 +950,8 @@ void ModuleDependencyScanner::discoverCrossImportOverlayDependencies(
950950
mainDep.addAuxiliaryFile(entry.second);
951951
cmdCopy.push_back("-swift-module-cross-import");
952952
cmdCopy.push_back(entry.first);
953-
cmdCopy.push_back(entry.second);
953+
auto overlayPath = cache.getScanService().remapPath(entry.second);
954+
cmdCopy.push_back(overlayPath);
954955
}
955956
mainDep.updateCommandLine(cmdCopy);
956957

test/CAS/path_remap.swift

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,14 @@
44
// RUN: %target-swift-frontend -scan-dependencies -module-name Test -module-cache-path %t/clang-module-cache -O \
55
// RUN: -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib \
66
// RUN: %t/main.swift -o %t/deps.json -swift-version 5 -cache-compile-job -cas-path %t/cas -I %t/include \
7-
// RUN: -scanner-prefix-map %swift_src_root=/^src -scanner-prefix-map %t=/^tmp
7+
// RUN: -scanner-prefix-map %swift_src_root=/^src -scanner-prefix-map %t=/^tmp -enable-cross-import-overlays
88

99
// RUN: %{python} %S/Inputs/BuildCommandExtractor.py %t/deps.json A > %t/A.cmd
1010
// RUN: %swift_frontend_plain @%t/A.cmd
11+
// RUN: %{python} %S/Inputs/BuildCommandExtractor.py %t/deps.json B > %t/B.cmd
12+
// RUN: %swift_frontend_plain @%t/B.cmd
13+
// RUN: %{python} %S/Inputs/BuildCommandExtractor.py %t/deps.json _B_A > %t/BA.cmd
14+
// RUN: %swift_frontend_plain @%t/BA.cmd
1115

1216
// RUN: %{python} %S/Inputs/GenerateExplicitModuleMap.py %t/deps.json > %t/map.json
1317
// RUN: llvm-cas --cas %t/cas --make-blob --data %t/map.json > %t/map.casid
@@ -19,7 +23,7 @@
1923
// RUN: -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib \
2024
// RUN: -module-name Test -explicit-swift-module-map-file @%t/map.casid \
2125
// RUN: -cache-replay-prefix-map /^src=%swift_src_root -cache-replay-prefix-map /^tmp=%t \
22-
// RUN: /^tmp/main.swift @%t/MyApp.cmd
26+
// RUN: /^tmp/main.swift @%t/MyApp.cmd -enable-cross-import-overlays
2327

2428
// RUN: %swift-scan-test -action compute_cache_key_from_index -cas-path %t/cas -input 0 -- \
2529
// RUN: %target-swift-frontend \
@@ -28,7 +32,7 @@
2832
// RUN: -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib \
2933
// RUN: -module-name Test -explicit-swift-module-map-file @%t/map.casid \
3034
// RUN: -cache-replay-prefix-map /^src=%swift_src_root -cache-replay-prefix-map /^tmp=%t \
31-
// RUN: /^tmp/main.swift @%t/MyApp.cmd > %t/key.casid
35+
// RUN: /^tmp/main.swift @%t/MyApp.cmd -enable-cross-import-overlays > %t/key.casid
3236

3337
// RUN: %swift-scan-test -action replay_result -cas-path %t/cas -id @%t/key.casid -- \
3438
// RUN: %target-swift-frontend \
@@ -37,15 +41,32 @@
3741
// RUN: -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib \
3842
// RUN: -module-name Test -explicit-swift-module-map-file @%t/map.casid \
3943
// RUN: -cache-replay-prefix-map /^src=%swift_src_root -cache-replay-prefix-map /^tmp=%t \
40-
// RUN: /^tmp/main.swift @%t/MyApp.cmd
44+
// RUN: /^tmp/main.swift @%t/MyApp.cmd -enable-cross-import-overlays
4145

4246
//--- main.swift
4347
import A
48+
import B
4449

4550
#warning("This is a warning")
4651

4752
//--- include/A.swiftinterface
4853
// swift-interface-format-version: 1.0
4954
// swift-module-flags: -module-name A -O -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib -user-module-version 1.0
55+
public func a() { }
56+
57+
//--- include/B.swiftinterface
58+
// swift-interface-format-version: 1.0
59+
// swift-module-flags: -module-name B -O -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib -user-module-version 1.0
5060
public func b() { }
5161

62+
//--- include/_B_A.swiftinterface
63+
// swift-interface-format-version: 1.0
64+
// swift-module-flags: -module-name _B_A -O -disable-implicit-string-processing-module-import -disable-implicit-concurrency-module-import -parse-stdlib -user-module-version 1.0
65+
public func b_a() { }
66+
67+
//--- include/B.swiftcrossimport/A.swiftoverlay
68+
%YAML 1.2
69+
---
70+
version: 1
71+
modules:
72+
- name: _B_A

0 commit comments

Comments
 (0)