Merge pull request swiftlang#70904 from tshortli/resolve-warnings

NFC: Resolve a bunch of warnings

Author: tshortli

lib/Parse/ParseDecl.cpp

@@ -7929,7 +7929,6 @@ void Parser::parseExpandedMemberList(SmallVectorImpl<ASTNode> &items) {
     consumeTokenWithoutFeedingReceiver();
 
   auto *decl = CurDeclContext->getAsDecl();
-  auto *idc = dyn_cast<IterableDeclContext>(decl);
   bool previousHadSemi = true;
 
   SourceLoc startingLoc = Tok.getLoc();

lib/SIL/Utils/InstructionUtils.cpp

@@ -917,7 +917,7 @@ RuntimeEffect swift::getRuntimeEffect(SILInstruction *inst, SILType &impactType)
     auto as = ApplySite(inst);
 
     switch (as.getSubstCalleeType()->getRepresentation()) {
-    case SILFunctionTypeRepresentation::ObjCMethod: {
+    case SILFunctionTypeRepresentation::ObjCMethod:
       if (auto *callee = as.getCalleeFunction()) {
         if (auto *clangDecl = callee->getClangDecl()) {
           if (auto clangMethodDecl = dyn_cast<clang::ObjCMethodDecl>(clangDecl)) {
@@ -927,7 +927,7 @@ RuntimeEffect swift::getRuntimeEffect(SILInstruction *inst, SILType &impactType)
           }
         }
       }
-    }
+      LLVM_FALLTHROUGH;
     case SILFunctionTypeRepresentation::Block:
       rt |= RuntimeEffect::ObjectiveC | RuntimeEffect::MetaData;
       break;

lib/SILOptimizer/SemanticARC/Transforms.h

@@ -33,7 +33,7 @@ struct Context;
 ///
 /// \returns true if we converted atleast one phi from owned -> guaranteed and
 /// eliminated ARC traffic as a result.
-bool tryConvertOwnedPhisToGuaranteedPhis(Context &ctx) LLVM_LIBRARY_VISIBILITY;
+LLVM_LIBRARY_VISIBILITY bool tryConvertOwnedPhisToGuaranteedPhis(Context &ctx);
 
 } // namespace semanticarc
 } // namespace swift

stdlib/public/runtime/BytecodeLayouts.cpp

@@ -396,7 +396,7 @@ static void singlePayloadEnumGeneric(const Metadata *metadata,
     auto tagBytesAndOffset = reader.readBytes<uint64_t>();
     auto payloadSize = reader.readBytes<size_t>();
     auto *xiType = reader.readBytes<const Metadata *>();
-    auto numEmptyCases = reader.readBytes<unsigned>();
+    (void)reader.readBytes<unsigned>();
     auto refCountBytes = reader.readBytes<size_t>();
     auto skip = reader.readBytes<size_t>();
 
@@ -616,7 +616,7 @@ static void singlePayloadEnumGeneric(const Metadata *metadata,
     auto tagBytesAndOffset = reader.readBytes<uint64_t>();
     auto payloadSize = reader.readBytes<size_t>();
     auto *xiType = reader.readBytes<const Metadata *>();
-    auto numEmptyCases = reader.readBytes<unsigned>();
+    (void)reader.readBytes<unsigned>(); // numEmptyCases
     auto refCountBytes = reader.readBytes<size_t>();
     auto skip = reader.readBytes<size_t>();
 
@@ -1655,7 +1655,7 @@ static void singlePayloadEnumGenericAssignWithCopy(const Metadata *metadata,
     auto tagBytesAndOffset = reader.readBytes<uint64_t>();
     auto payloadSize = reader.readBytes<size_t>();
     auto *xiType = reader.readBytes<const Metadata *>();
-    auto numEmptyCases = reader.readBytes<unsigned>();
+    (void)reader.readBytes<unsigned>(); // numEmptyCases
     auto refCountBytes = reader.readBytes<size_t>();
     auto skip = reader.readBytes<size_t>();
 

stdlib/public/runtime/ErrorObject.mm

@@ -110,7 +110,7 @@ - (void)dealloc {
   auto copy = type->allocateBufferIn(&copyBuf);
   error->type->vw_initializeWithCopy(copy, const_cast<OpaqueValue *>(value));
 
-  auto description = getDescription(copy, type);
+  id description = getDescription(copy, type);
   type->deallocateBufferIn(&copyBuf);
   return description;
 }

stdlib/public/runtime/ProtocolConformance.cpp

@@ -1330,7 +1330,8 @@ satisfiesLayoutConstraint(const GenericRequirementDescriptor &req,
   }
 
   // Unknown layout.
-  return TYPE_LOOKUP_ERROR_FMT("unknown layout kind %u", req.getLayout());
+  return TYPE_LOOKUP_ERROR_FMT("unknown layout kind %u",
+                               static_cast<uint32_t>(req.getLayout()));
 }
 
 SWIFT_CC(swift)

stdlib/toolchain/Compatibility56/include/Concurrency/Threading/Mutex.h

@@ -982,26 +982,35 @@ using SmallMutex =
 
 // Enforce literal requirements for static variants.
 #if SWIFT_MUTEX_SUPPORTS_CONSTEXPR
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 static_assert(std::is_literal_type<StaticMutex>::value,
               "StaticMutex must be literal type");
 static_assert(std::is_literal_type<StaticUnsafeMutex>::value,
               "StaticUnsafeMutex must be literal type");
+#pragma clang diagnostic pop
 #else
 // Your platform doesn't currently support statically allocated Mutex
 // you will possibly see global-constructors warnings
 #endif
 
 #if SWIFT_CONDITION_SUPPORTS_CONSTEXPR
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 static_assert(std::is_literal_type<StaticConditionVariable>::value,
               "StaticConditionVariable must be literal type");
+#pragma clang diagnostic pop
 #else
 // Your platform doesn't currently support statically allocated ConditionVar
 // you will possibly see global-constructors warnings
 #endif
 
 #if SWIFT_READWRITELOCK_SUPPORTS_CONSTEXPR
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 static_assert(std::is_literal_type<StaticReadWriteLock>::value,
               "StaticReadWriteLock must be literal type");
+#pragma clang diagnostic pop
 #else
 // Your platform doesn't currently support statically allocated ReadWriteLocks
 // you will possibly see global-constructors warnings