SILPrinter: print linkage for external globals.

Unlike SIL functions, there is no way to distinguish a global declaration from a global definition - other than the linkage.

Author: eeckstein

lib/SIL/IR/SILPrinter.cpp

@@ -2701,7 +2701,9 @@ void SILGlobalVariable::print(llvm::raw_ostream &OS, bool Verbose) const {
   printClangQualifiedNameCommentIfPresent(OS, getClangDecl());
 
   OS << "sil_global ";
-  printLinkage(OS, getLinkage(), isDefinition());
+  // Passing true for 'isDefinition' lets print the (external) linkage if it's
+  // not a definition.
+  printLinkage(OS, getLinkage(), /*isDefinition*/ true);
 
   if (isSerialized())
     OS << "[serialized] ";

test/Interop/Cxx/extern-var/extern-var-silgen.swift

@@ -7,9 +7,9 @@ func getCounter() -> CInt {
 }
 
 // CHECK: // clang name: counter
-// CHECK: sil_global @counter : $Int32
+// CHECK: sil_global public_external @counter : $Int32
 // CHECK: // clang name: Namespaced::counter
-// CHECK: sil_global @{{_ZN10Namespaced7counterE|\?counter@Namespaced@@3HA}} : $Int32
+// CHECK: sil_global public_external @{{_ZN10Namespaced7counterE|\?counter@Namespaced@@3HA}} : $Int32
 
 // CHECK: sil hidden @$s4main10getCounters5Int32VyF : $@convention(thin) () -> Int32
 // CHECK: [[COUNTER:%.*]] = global_addr @counter : $*Int32

test/Interop/Cxx/static/inline-static-member-var-silgen.swift

@@ -7,7 +7,7 @@ func readStaticMember() -> CInt {
 }
 
 // CHECK: // clang name: WithInlineStaticMember::staticMember
-// CHECK: sil_global @{{_ZN22WithInlineStaticMember12staticMemberE|\?staticMember@WithInlineStaticMember@@2HA}} : $Int32
+// CHECK: sil_global public_external @{{_ZN22WithInlineStaticMember12staticMemberE|\?staticMember@WithInlineStaticMember@@2HA}} : $Int32
 
 // CHECK: sil hidden @$s4main16readStaticMembers5Int32VyF : $@convention(thin) () -> Int32
 // CHECK: [[ADDR:%.*]] = global_addr @{{_ZN22WithInlineStaticMember12staticMemberE|\?staticMember@WithInlineStaticMember@@2HA}} : $*Int32

test/Interop/Cxx/static/static-member-var-silgen.swift

@@ -1,15 +1,15 @@
 // RUN: %target-swift-emit-sil -I %S/Inputs -enable-cxx-interop %s | %FileCheck %s
 
 // CHECK: // clang name: WithStaticMember::staticMember
-// CHECK: sil_global @{{_ZN16WithStaticMember12staticMemberE|\?staticMember@WithStaticMember@@2HA}} : $Int32
+// CHECK: sil_global public_external @{{_ZN16WithStaticMember12staticMemberE|\?staticMember@WithStaticMember@@2HA}} : $Int32
 // CHECK: // clang name: WithIncompleteStaticMember::selfMember
-// CHECK: sil_global @{{_ZN26WithIncompleteStaticMember10selfMemberE|\?selfMember@WithIncompleteStaticMember@@2V1@A}} : $WithIncompleteStaticMember
+// CHECK: sil_global public_external @{{_ZN26WithIncompleteStaticMember10selfMemberE|\?selfMember@WithIncompleteStaticMember@@2V1@A}} : $WithIncompleteStaticMember
 // CHECK: // clang name: WithConstStaticMember::defined
-// CHECK: sil_global [let] @{{_ZN21WithConstStaticMember7definedE|\?defined@WithConstStaticMember@@2HB}} : $Int32
+// CHECK: sil_global public_external [let] @{{_ZN21WithConstStaticMember7definedE|\?defined@WithConstStaticMember@@2HB}} : $Int32
 // CHECK: // clang name: WithConstStaticMember::definedOutOfLine
-// CHECK: sil_global [let] @{{_ZN21WithConstStaticMember16definedOutOfLineE|\?definedOutOfLine@WithConstStaticMember@@2HB}} : $Int32
+// CHECK: sil_global public_external [let] @{{_ZN21WithConstStaticMember16definedOutOfLineE|\?definedOutOfLine@WithConstStaticMember@@2HB}} : $Int32
 // CHECK: // clang name: WithConstexprStaticMember::definedInline
-// CHECK: sil_global [let] @{{_ZN25WithConstexprStaticMember13definedInlineE|\?definedInline@WithConstexprStaticMember@@2HB}} : $Int32
+// CHECK: sil_global public_external [let] @{{_ZN25WithConstexprStaticMember13definedInlineE|\?definedInline@WithConstexprStaticMember@@2HB}} : $Int32
 
 import StaticMemberVar
 

test/Interop/Cxx/static/static-var-silgen.swift

@@ -9,25 +9,25 @@ func initStaticVars() -> CInt {
 }
 
 // CHECK: // clang name: staticVar
-// CHECK: sil_global @staticVar : $Int32
+// CHECK: sil_global public_external @staticVar : $Int32
 // CHECK: // clang name: staticVarInit
-// CHECK: sil_global @staticVarInit : $Int32
+// CHECK: sil_global public_external @staticVarInit : $Int32
 // CHECK: // clang name: staticVarInlineInit
-// CHECK: sil_global @staticVarInlineInit : $Int32
+// CHECK: sil_global public_external @staticVarInlineInit : $Int32
 // CHECK: // clang name: staticConst
-// CHECK: sil_global [let] @staticConst : $Int32
+// CHECK: sil_global public_external [let] @staticConst : $Int32
 // CHECK: // clang name: staticConstInit
-// CHECK: sil_global [let] @staticConstInit : $Int32
+// CHECK: sil_global public_external [let] @staticConstInit : $Int32
 // CHECK: // clang name: staticConstInlineInit
-// CHECK: sil_global [let] @staticConstInlineInit : $Int32
+// CHECK: sil_global public_external [let] @staticConstInlineInit : $Int32
 // CHECK: // clang name: staticConstexpr
-// CHECK: sil_global [let] @staticConstexpr : $Int32
+// CHECK: sil_global public_external [let] @staticConstexpr : $Int32
 // CHECK: // clang name: staticNonTrivial
-// CHECK: sil_global @staticNonTrivial : $NonTrivial
+// CHECK: sil_global public_external @staticNonTrivial : $NonTrivial
 // CHECK: // clang name: staticConstNonTrivial
-// CHECK: sil_global [let] @staticConstNonTrivial : $NonTrivial
+// CHECK: sil_global public_external [let] @staticConstNonTrivial : $NonTrivial
 // CHECK: // clang name: staticConstexprNonTrivial
-// CHECK: sil_global [let] @staticConstexprNonTrivial : $NonTrivial
+// CHECK: sil_global public_external [let] @staticConstexprNonTrivial : $NonTrivial
 
 func readStaticVar() -> CInt {
   return staticVar

test/SILGen/dso_handle.swift

@@ -1,6 +1,6 @@
 // RUN: %target-swift-emit-silgen -Xllvm -sil-full-demangle %s | %FileCheck %s
 
-// CHECK: sil_global [[DSO:@__dso_handle|@__ImageBase]] : $Builtin.RawPointer
+// CHECK: sil_global public_external [[DSO:@__dso_handle|@__ImageBase]] : $Builtin.RawPointer
 
 // CHECK-LABEL: sil [ossa] @main : $@convention(c)
 // CHECK: bb0