Skip to content

Commit 4b2cbd6

Browse files
committed
build: rename prefix for _add_swift_host_library_single
1 parent a32b479 commit 4b2cbd6

File tree

1 file changed

+31
-34
lines changed

1 file changed

+31
-34
lines changed

cmake/modules/AddSwift.cmake

Lines changed: 31 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -693,77 +693,74 @@ endfunction()
693693
# source1 ...
694694
# Sources to add into this library
695695
function(_add_swift_host_library_single target)
696-
set(SWIFTLIB_SINGLE_options
696+
set(options
697697
SHARED
698698
STATIC)
699-
set(SWIFTLIB_SINGLE_single_parameter_options)
700-
set(SWIFTLIB_SINGLE_multiple_parameter_options
699+
set(single_parameter_options)
700+
set(multiple_parameter_options
701701
GYB_SOURCES
702702
LLVM_LINK_COMPONENTS)
703703

704-
cmake_parse_arguments(SWIFTLIB_SINGLE
705-
"${SWIFTLIB_SINGLE_options}"
706-
"${SWIFTLIB_SINGLE_single_parameter_options}"
707-
"${SWIFTLIB_SINGLE_multiple_parameter_options}"
704+
cmake_parse_arguments(ASHLS
705+
"${options}"
706+
"${single_parameter_options}"
707+
"${multiple_parameter_options}"
708708
${ARGN})
709+
set(ASHLS_SOURCES ${ASHLS_UNPARSED_ARGUMENTS})
709710

710-
set(SWIFTLIB_SINGLE_SOURCES ${SWIFTLIB_SINGLE_UNPARSED_ARGUMENTS})
711-
712-
translate_flags(SWIFTLIB_SINGLE "${SWIFTLIB_SINGLE_options}")
711+
translate_flags(ASHLS "${options}")
713712

714-
if(NOT SWIFTLIB_SINGLE_SHARED AND NOT SWIFTLIB_SINGLE_STATIC)
713+
if(NOT ASHLS_SHARED AND NOT ASHLS_STATIC)
715714
message(FATAL_ERROR "Either SHARED or STATIC must be specified")
716715
endif()
717716

718717
# Determine the subdirectory where this library will be installed.
719-
set(SWIFTLIB_SINGLE_SUBDIR
718+
set(ASHLS_SUBDIR
720719
"${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}/${SWIFT_HOST_VARIANT_ARCH}")
721720

722721
# Include LLVM Bitcode slices for iOS, Watch OS, and Apple TV OS device libraries.
723722
set(embed_bitcode_arg)
724723
if(SWIFT_EMBED_BITCODE_SECTION)
725724
if(SWIFT_HOST_VARIANT_SDK MATCHES "(I|TV|WATCH)OS")
726-
list(APPEND SWIFTLIB_SINGLE_C_COMPILE_FLAGS "-fembed-bitcode")
725+
list(APPEND ASHLS_C_COMPILE_FLAGS "-fembed-bitcode")
727726
set(embed_bitcode_arg EMBED_BITCODE)
728727
endif()
729728
endif()
730729

731730
if(XCODE)
732731
string(REGEX MATCHALL "/[^/]+" split_path ${CMAKE_CURRENT_SOURCE_DIR})
733732
list(GET split_path -1 dir)
734-
file(GLOB_RECURSE SWIFTLIB_SINGLE_HEADERS
733+
file(GLOB_RECURSE ASHLS_HEADERS
735734
${SWIFT_SOURCE_DIR}/include/swift${dir}/*.h
736735
${SWIFT_SOURCE_DIR}/include/swift${dir}/*.def
737736
${CMAKE_CURRENT_SOURCE_DIR}/*.def)
738737

739-
file(GLOB_RECURSE SWIFTLIB_SINGLE_TDS
738+
file(GLOB_RECURSE ASHLS_TDS
740739
${SWIFT_SOURCE_DIR}/include/swift${dir}/*.td)
741740

742-
set_source_files_properties(${SWIFTLIB_SINGLE_HEADERS} ${SWIFTLIB_SINGLE_TDS}
741+
set_source_files_properties(${ASHLS_HEADERS} ${ASHLS_TDS}
743742
PROPERTIES
744743
HEADER_FILE_ONLY true)
745-
source_group("TableGen descriptions" FILES ${SWIFTLIB_SINGLE_TDS})
744+
source_group("TableGen descriptions" FILES ${ASHLS_TDS})
746745

747-
set(SWIFTLIB_SINGLE_SOURCES ${SWIFTLIB_SINGLE_SOURCES} ${SWIFTLIB_SINGLE_HEADERS} ${SWIFTLIB_SINGLE_TDS})
746+
set(ASHLS_SOURCES ${ASHLS_SOURCES} ${ASHLS_HEADERS} ${ASHLS_TDS})
748747
endif()
749748

750-
if(SWIFTLIB_SINGLE_SHARED)
749+
if(ASHLS_SHARED)
751750
set(libkind SHARED)
752-
elseif(SWIFTLIB_SINGLE_STATIC)
751+
elseif(ASHLS_STATIC)
753752
set(libkind STATIC)
754753
endif()
755754

756-
if(SWIFTLIB_SINGLE_GYB_SOURCES)
755+
if(ASHLS_GYB_SOURCES)
757756
handle_gyb_sources(
758757
gyb_dependency_targets
759-
SWIFTLIB_SINGLE_GYB_SOURCES
758+
ASHLS_GYB_SOURCES
760759
"${SWIFT_HOST_VARIANT_ARCH}")
761-
set(SWIFTLIB_SINGLE_SOURCES ${SWIFTLIB_SINGLE_SOURCES}
762-
${SWIFTLIB_SINGLE_GYB_SOURCES})
760+
set(ASHLS_SOURCES ${ASHLS_SOURCES} ${ASHLS_GYB_SOURCES})
763761
endif()
764762

765-
add_library("${target}" ${libkind}
766-
${SWIFTLIB_SINGLE_SOURCES})
763+
add_library("${target}" ${libkind} ${ASHLS_SOURCES})
767764
_set_target_prefix_and_suffix("${target}" "${libkind}" "${SWIFT_HOST_VARIANT_SDK}")
768765

769766
if("${SWIFT_HOST_VARIANT_SDK}" STREQUAL "WINDOWS")
@@ -818,18 +815,18 @@ function(_add_swift_host_library_single target)
818815
${LLVM_COMMON_DEPENDS})
819816

820817
# Call llvm_config() only for libraries that are part of the compiler.
821-
swift_common_llvm_config("${target}" ${SWIFTLIB_SINGLE_LLVM_LINK_COMPONENTS})
818+
swift_common_llvm_config("${target}" ${ASHLS_LLVM_LINK_COMPONENTS})
822819

823820
# Collect compile and link flags for the static and non-static targets.
824821
# Don't set PROPERTY COMPILE_FLAGS or LINK_FLAGS directly.
825-
set(c_compile_flags ${SWIFTLIB_SINGLE_C_COMPILE_FLAGS})
822+
set(c_compile_flags ${ASHLS_C_COMPILE_FLAGS})
826823
set(link_flags)
827824

828825
set(library_search_subdir "${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}")
829826
set(library_search_directories
830-
"${SWIFTLIB_DIR}/${SWIFTLIB_SINGLE_SUBDIR}"
831-
"${SWIFT_NATIVE_SWIFT_TOOLS_PATH}/../lib/swift/${SWIFTLIB_SINGLE_SUBDIR}"
832-
"${SWIFT_NATIVE_SWIFT_TOOLS_PATH}/../lib/swift/${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}")
827+
"${SWIFTLIB_DIR}/${ASHLS_SUBDIR}"
828+
"${SWIFT_NATIVE_SWIFT_TOOLS_PATH}/../lib/swift/${ASHLS_SUBDIR}"
829+
"${SWIFT_NATIVE_SWIFT_TOOLS_PATH}/../lib/swift/${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}")
833830

834831
# In certain cases when building, the environment variable SDKROOT is set to override
835832
# where the sdk root is located in the system. If that environment variable has been
@@ -840,7 +837,7 @@ function(_add_swift_host_library_single target)
840837
endif()
841838

842839
_add_variant_c_compile_flags(
843-
SDK "${SWIFT_HOST_VARIANT_SDK}"
840+
SDK "${SWIFT_HOST_VARIANT_SDK}"
844841
ARCH "${SWIFT_HOST_VARIANT_ARCH}"
845842
BUILD_TYPE ${CMAKE_BUILD_TYPE}
846843
ENABLE_ASSERTIONS ${LLVM_ENABLE_ASSERTIONS}
@@ -874,9 +871,9 @@ function(_add_swift_host_library_single target)
874871
${${SWIFT_HOST_VARIANT_ARCH}_INCLUDE})
875872

876873
if(NOT ${CMAKE_C_COMPILER_ID} STREQUAL MSVC)
877-
swift_windows_get_sdk_vfs_overlay(SWIFTLIB_SINGLE_VFS_OVERLAY)
874+
swift_windows_get_sdk_vfs_overlay(ASHLS_VFS_OVERLAY)
878875
target_compile_options(${target} PRIVATE
879-
"SHELL:-Xclang -ivfsoverlay -Xclang ${SWIFTLIB_SINGLE_VFS_OVERLAY}")
876+
"SHELL:-Xclang -ivfsoverlay -Xclang ${ASHLS_VFS_OVERLAY}")
880877

881878
# MSVC doesn't support -Xclang. We don't need to manually specify
882879
# the dependent libraries as `cl` does so.

0 commit comments

Comments
 (0)