Skip to content

Commit 4d88150

Browse files
author
David Ungar
authored
Merge pull request swiftlang#28640 from davidungar/12-8-rename-experimental-to-fine
[Driver, NFC] Finish rename of experimental dependencies to fine-grained dependencies
2 parents 171987a + 0771d96 commit 4d88150

File tree

1 file changed

+20
-18
lines changed

1 file changed

+20
-18
lines changed

lib/Driver/Compilation.cpp

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,8 @@ namespace driver {
244244
CoarseGrainedDependencyGraph CoarseGrainedDepGraph;
245245
CoarseGrainedDependencyGraph CoarseGrainedDepGraphForRanges;
246246

247-
fine_grained_dependencies::ModuleDepGraph ExpDepGraph;
248-
fine_grained_dependencies::ModuleDepGraph ExpDepGraphForRanges;
247+
fine_grained_dependencies::ModuleDepGraph FineGrainedDepGraph;
248+
fine_grained_dependencies::ModuleDepGraph FineGrainedDepGraphForRanges;
249249

250250
private:
251251
/// Helper for tracing the propagation of marks in the graph.
@@ -288,7 +288,7 @@ namespace driver {
288288
<< reason << ": " << LogJob(cmd) << "\n";
289289

290290
if (Comp.getEnableFineGrainedDependencies())
291-
getExpDepGraph(forRanges).printPath(llvm::outs(), cmd);
291+
getFineGrainedDepGraph(forRanges).printPath(llvm::outs(), cmd);
292292
else
293293
IncrementalTracer->printPath(
294294
llvm::outs(), cmd, [](raw_ostream &out, const Job *base) {
@@ -806,11 +806,11 @@ namespace driver {
806806
public:
807807
PerformJobsState(Compilation &Comp, std::unique_ptr<TaskQueue> &&TaskQueue)
808808
: Comp(Comp),
809-
ExpDepGraph(
809+
FineGrainedDepGraph(
810810
Comp.getVerifyFineGrainedDependencyGraphAfterEveryImport(),
811811
Comp.getEmitFineGrainedDependencyDotFileAfterEveryImport(),
812812
Comp.getTraceDependencies(), Comp.getStatsReporter()),
813-
ExpDepGraphForRanges(
813+
FineGrainedDepGraphForRanges(
814814
Comp.getVerifyFineGrainedDependencyGraphAfterEveryImport(),
815815
Comp.getEmitFineGrainedDependencyDotFileAfterEveryImport(),
816816
Comp.getTraceDependencies(), Comp.getStatsReporter()),
@@ -1008,7 +1008,7 @@ namespace driver {
10081008
Cmd, Cond, HasDependenciesFileName);
10091009

10101010
if (Comp.getEnableFineGrainedDependencies())
1011-
assert(getExpDepGraph(/*forRanges=*/false)
1011+
assert(getFineGrainedDepGraph(/*forRanges=*/false)
10121012
.emitDotFileAndVerify(Comp.getDiags()));
10131013
return std::make_pair(shouldSched, isCascading);
10141014
}
@@ -1560,13 +1560,13 @@ namespace driver {
15601560

15611561
bool isMarkedInDepGraph(const Job *const Cmd, const bool forRanges) {
15621562
return Comp.getEnableFineGrainedDependencies()
1563-
? getExpDepGraph(forRanges).isMarked(Cmd)
1563+
? getFineGrainedDepGraph(forRanges).isMarked(Cmd)
15641564
: getDepGraph(forRanges).isMarked(Cmd);
15651565
}
15661566

15671567
std::vector<StringRef> getExternalDependencies(const bool forRanges) const {
15681568
if (Comp.getEnableFineGrainedDependencies())
1569-
return getExpDepGraph(forRanges).getExternalDependencies();
1569+
return getFineGrainedDepGraph(forRanges).getExternalDependencies();
15701570
const auto deps = getDepGraph(forRanges).getExternalDependencies();
15711571
std::vector<StringRef> Dependencies;
15721572
std::copy(std::begin(deps), std::end(deps),
@@ -1579,22 +1579,24 @@ namespace driver {
15791579
StringRef externalDependency,
15801580
const bool forRanges) {
15811581
if (Comp.getEnableFineGrainedDependencies())
1582-
getExpDepGraph(forRanges).markExternal(uses, externalDependency);
1582+
getFineGrainedDepGraph(forRanges).markExternal(uses,
1583+
externalDependency);
15831584
else
15841585
getDepGraph(forRanges).markExternal(uses, externalDependency);
15851586
}
15861587

15871588
bool markIntransitiveInDepGraph(const Job *Cmd, const bool forRanges) {
15881589
return Comp.getEnableFineGrainedDependencies()
1589-
? getExpDepGraph(forRanges).markIntransitive(Cmd)
1590+
? getFineGrainedDepGraph(forRanges).markIntransitive(Cmd)
15901591
: getDepGraph(forRanges).markIntransitive(Cmd);
15911592
}
15921593

15931594
CoarseGrainedDependencyGraph::LoadResult
15941595
loadDepGraphFromPath(const Job *Cmd, StringRef path,
15951596
DiagnosticEngine &diags, const bool forRanges) {
15961597
return Comp.getEnableFineGrainedDependencies()
1597-
? getExpDepGraph(forRanges).loadFromPath(Cmd, path, diags)
1598+
? getFineGrainedDepGraph(forRanges).loadFromPath(Cmd, path,
1599+
diags)
15981600
: getDepGraph(forRanges).loadFromPath(Cmd, path, diags);
15991601
}
16001602

@@ -1604,28 +1606,28 @@ namespace driver {
16041606
const bool forRanges,
16051607
CoarseGrainedDependencyGraph::MarkTracer *tracer = nullptr) {
16061608
if (Comp.getEnableFineGrainedDependencies())
1607-
getExpDepGraph(forRanges).markTransitive(visited, Cmd, tracer);
1609+
getFineGrainedDepGraph(forRanges).markTransitive(visited, Cmd, tracer);
16081610
else
16091611
getDepGraph(forRanges).markTransitive(visited, Cmd, tracer);
16101612
}
16111613

16121614
void addIndependentNodeToDepGraph(const Job *Cmd, const bool forRanges) {
16131615
if (Comp.getEnableFineGrainedDependencies())
1614-
getExpDepGraph(forRanges).addIndependentNode(Cmd);
1616+
getFineGrainedDepGraph(forRanges).addIndependentNode(Cmd);
16151617
else
16161618
getDepGraph(forRanges).addIndependentNode(Cmd);
16171619
}
16181620

16191621
fine_grained_dependencies::ModuleDepGraph &
1620-
getExpDepGraph(const bool forRanges) {
1621-
return forRanges ? ExpDepGraphForRanges : ExpDepGraph;
1622+
getFineGrainedDepGraph(const bool forRanges) {
1623+
return forRanges ? FineGrainedDepGraphForRanges : FineGrainedDepGraph;
16221624
}
16231625
CoarseGrainedDependencyGraph &getDepGraph(const bool forRanges) {
16241626
return forRanges ? CoarseGrainedDepGraphForRanges : CoarseGrainedDepGraph;
16251627
}
16261628
const fine_grained_dependencies::ModuleDepGraph &
1627-
getExpDepGraph(const bool forRanges) const {
1628-
return forRanges ? ExpDepGraphForRanges : ExpDepGraph;
1629+
getFineGrainedDepGraph(const bool forRanges) const {
1630+
return forRanges ? FineGrainedDepGraphForRanges : FineGrainedDepGraph;
16291631
}
16301632
const CoarseGrainedDependencyGraph &
16311633
getDepGraph(const bool forRanges) const {
@@ -1825,7 +1827,7 @@ int Compilation::performJobsImpl(bool &abnormalExit,
18251827
}
18261828
}
18271829
if (getEnableFineGrainedDependencies())
1828-
assert(State.ExpDepGraph.emitDotFileAndVerify(getDiags()));
1830+
assert(State.FineGrainedDepGraph.emitDotFileAndVerify(getDiags()));
18291831
abnormalExit = State.hadAnyAbnormalExit();
18301832
return State.getResult();
18311833
}

0 commit comments

Comments
 (0)