IRGen Mandatory Module Pass: Pass large loadable types by address instead of by value

Author: Joe Shajrawi

include/swift/IRGen/IRGenSILPasses.h

@@ -12,12 +12,13 @@
 
 namespace swift {
 
-class SILFunctionTransform;
+class SILTransform;
 
 namespace irgen {
 
 /// Create a pass to hoist alloc_stack instructions with non-fixed size.
-SILFunctionTransform *createAllocStackHoisting();
+SILTransform *createAllocStackHoisting();
+SILTransform *createLoadableByAddress();
 
 } // end namespace irgen
 } // end namespace swift

include/swift/SIL/SILFunction.h

@@ -239,9 +239,9 @@ class SILFunction
   /// or return instructions; you need to do that yourself
   /// if you care.
   ///
-  /// This is a hack and should be removed!
+  /// This routine does not update all the references in the module
+  /// You have to do that yourself
   void rewriteLoweredTypeUnsafe(CanSILFunctionType newType) {
-    assert(canBeDeleted());
     LoweredType = newType;
   }
 

include/swift/SILOptimizer/PassManager/PassManager.h

@@ -99,7 +99,7 @@ class SILPassManager {
 
 
   /// The IRGen SIL passes. These have to be dynamically added by IRGen.
-  llvm::DenseMap<unsigned, SILFunctionTransform *> IRGenPasses;
+  llvm::DenseMap<unsigned, SILTransform *> IRGenPasses;
 
 public:
   /// C'tor. It creates and registers all analysis passes, which are defined
@@ -247,7 +247,7 @@ class SILPassManager {
     }
   }
 
-  void registerIRGenPass(PassKind Kind, SILFunctionTransform *Transform) {
+  void registerIRGenPass(PassKind Kind, SILTransform *Transform) {
     assert(IRGenPasses.find(unsigned(Kind)) == IRGenPasses.end() &&
            "Pass already registered");
     assert(

include/swift/SILOptimizer/PassManager/Passes.def

@@ -222,6 +222,8 @@ PASS(ReleaseHoisting, "release-hoisting",
      "SIL release Hoisting")
 PASS(LateReleaseHoisting, "late-release-hoisting",
      "Late SIL release Hoisting Preserving Epilogues")
+IRGEN_PASS(LoadableByAddress, "loadable-address",
+           "SIL Loadable type by-address lowering.")
 PASS(RemovePins, "remove-pins",
      "Remove SIL pin/unpin pairs")
 PASS(SideEffectsDumper, "side-effects-dump",

include/swift/SILOptimizer/PassManager/Transforms.h

@@ -66,6 +66,12 @@ namespace swift {
     /// Inject the pass manager running this pass.
     void injectPassManager(SILPassManager *PMM) { PM = PMM; }
 
+    irgen::IRGenModule *getIRGenModule() {
+      auto *Mod = PM->getIRGenModule();
+      assert(Mod && "Expecting a valid module");
+      return Mod;
+    }
+
     /// Get the name of the transform.
     llvm::StringRef getName() { return PassKindName(getPassKind()); }
 
@@ -116,12 +122,6 @@ namespace swift {
   protected:
     SILFunction *getFunction() { return F; }
 
-    irgen::IRGenModule *getIRGenModule() {
-      auto *Mod = PM->getIRGenModule();
-      assert(Mod && "Expecting a valid module");
-      return Mod;
-    }
-
     void invalidateAnalysis(SILAnalysis::InvalidationKind K) {
       PM->invalidateAnalysis(F, K);
     }

lib/IRGen/AllocStackHoisting.cpp

@@ -427,6 +427,6 @@ class AllocStackHoisting : public SILFunctionTransform {
 };
 } // end anonymous namespace
 
-SILFunctionTransform *irgen::createAllocStackHoisting() {
+SILTransform *irgen::createAllocStackHoisting() {
   return new AllocStackHoisting();
 }

lib/IRGen/CMakeLists.txt

@@ -38,6 +38,7 @@ add_swift_library(swiftIRGen STATIC
   IRGenModule.cpp
   IRGenSIL.cpp
   Linking.cpp
+  LoadableByAddress.cpp
   LocalTypeData.cpp
   StructLayout.cpp
   SwiftTargetInfo.cpp